LT-22261: Problems with copied text when importing from flextext#488
Merged
Conversation
papeh
reviewed
Oct 17, 2025
papeh
left a comment
Contributor
There was a problem hiding this comment.
LG through BIRD line 1000; I'll look at the rest after lunch.
@papeh reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
Src/LexText/Interlinear/BIRDInterlinearImporter.cs line 865 at r1 (raw file):
foreach (var item in word.Items) { if (wordForm.Analysis.CategoryRA != null)
What besides line 880 wordForm.Analysis.CategoryRA = cat; might set CategoryRA in this loop?
papeh
approved these changes
Oct 17, 2025
papeh
left a comment
Contributor
There was a problem hiding this comment.
@papeh reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jtmaxwell3)
Src/LexText/Interlinear/ITextDllTests/BIRDFormatImportTests.cs line 827 at r1 (raw file):
ISegment segment = imported.ContentsOA[0].SegmentsOS[0]; // Verify that we found the category. Assert.True(segment.AnalysesRS[0].Analysis.CategoryRA.Equals(cat));
nit: you could get more helpful error reports from
Assert.That(segment.AnalysesRS[0].Analysis.CategoryRA).Is.Equalto(cat);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several bugs in the flextext importer:
There is also a bug where an extra § is inserted.
I'm going to create JIRA issues for the bugs.
This change is