LT-3646: Unchecked checkboxes count as "no data"#494
Merged
Conversation
When determining field visibility, treat unchecked checkboxes as if they have "no data". Note: This change applies to all checkboxes stored as a Boolean, and one checkbox that is stored as an integer. To apply the new behavior to a checkbox stored as an integer, and avoid changing the behavior of all integer fields, we specifically identify the integer field. There is a possibility that we missed other checkbox fields that are stored as an integer. Change-Id: Ia039b97f42727314b54d8d0b0303b7ca141b33e4
papeh
approved these changes
Oct 21, 2025
| return NodeTestResult.kntrNothing; | ||
| break; | ||
| case CellarPropertyType.Integer: | ||
| // This is displayed as a checkbox. |
Contributor
There was a problem hiding this comment.
"Hide Minor Entry is displayed as a checkbox" would be more clear.
Change-Id: Ibc8327d9c3d983b75a20c0d44a66517201b8cafc
mark-sil
commented
Oct 21, 2025
mark-sil
left a comment
mark-sil
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @papeh)
| return NodeTestResult.kntrNothing; | ||
| break; | ||
| case CellarPropertyType.Integer: | ||
| // This is displayed as a checkbox. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When determining field visibility, treat unchecked checkboxes as if they have "no data".
Note: This change applies to all checkboxes stored as a Boolean, and one checkbox that is stored as an integer. To apply the new behavior to a checkbox stored as an integer, and avoid changing the behavior of all integer fields, we specifically identify the integer field. There is a possibility that we missed other checkbox fields that are stored as an integer.
Change-Id: Ia039b97f42727314b54d8d0b0303b7ca141b33e4
This change is