Skip to content

LT-22298: Fix Patching: set both build numbers#495

Merged
papeh merged 4 commits into
release/9.3from
LT-22298
Oct 23, 2025
Merged

LT-22298: Fix Patching: set both build numbers#495
papeh merged 4 commits into
release/9.3from
LT-22298

Conversation

@papeh

@papeh papeh commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

FW_BUILD_NUMBER sets the build number on assemblies; BuildVersionSegment sets it on the installer.

NAnt required base installers to be x.x.x.1; WiX may not. I should test whether having a higher-numbered base build works, as this would allow us to get rid of an otherwise redundant variable.

Add summary documentation to installer workflows.

Change-Id: Icb0fd8934cf21c823a9c1490fa2647960bcb1ac4


This change is Reviewable

FW_BUILD_NUMBER sets the build number on assemblies;
BuildVersionSegment sets it on the installer.

NAnt required base installers to be x.x.x.1; WiX may not.
I should test whether having a higher-numbered base build
works, as this would allow us to get rid of an otherwise
redundant variable.

Add summary documentation to installer workflows.

Change-Id: Icb0fd8934cf21c823a9c1490fa2647960bcb1ac4
@jasonleenaylor

Copy link
Copy Markdown
Contributor

.github/workflows/patch-installer-cd.yml line 269 at r1 (raw file):

        run: |
          # The github action base-installer-cd will make releases with a tag build-[build number].
          # REVIEW (Hasso) 2025.10: we gave up on targeting Jenkins bases; how much of this is obsolete?

I think the comment is obsolete, we still have to be able to build against a previous release so we can patch our stable and our betas. I think everything in here is needed for our current uses.

papeh added 2 commits October 23, 2025 09:50
Change-Id: I7c8889f58e13169a90022d5729f8b4016cc67ff6
Change-Id: I399f6d7d1e1acd995b4a141347f6b8dfb2043d06

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 2 of 2 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @papeh)

@papeh papeh enabled auto-merge (squash) October 23, 2025 20:33
@papeh papeh merged commit e1cac24 into release/9.3 Oct 23, 2025
5 checks passed
@papeh papeh deleted the LT-22298 branch October 23, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants