LT-22298: Fix Patching: set both build numbers#495
Merged
Conversation
FW_BUILD_NUMBER sets the build number on assemblies; BuildVersionSegment sets it on the installer. NAnt required base installers to be x.x.x.1; WiX may not. I should test whether having a higher-numbered base build works, as this would allow us to get rid of an otherwise redundant variable. Add summary documentation to installer workflows. Change-Id: Icb0fd8934cf21c823a9c1490fa2647960bcb1ac4
Contributor
|
I think the comment is obsolete, we still have to be able to build against a previous release so we can patch our stable and our betas. I think everything in here is needed for our current uses. |
Change-Id: I7c8889f58e13169a90022d5729f8b4016cc67ff6
Change-Id: I399f6d7d1e1acd995b4a141347f6b8dfb2043d06
jasonleenaylor
approved these changes
Oct 23, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 of 2 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @papeh)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FW_BUILD_NUMBER sets the build number on assemblies; BuildVersionSegment sets it on the installer.
NAnt required base installers to be x.x.x.1; WiX may not. I should test whether having a higher-numbered base build works, as this would allow us to get rid of an otherwise redundant variable.
Add summary documentation to installer workflows.
Change-Id: Icb0fd8934cf21c823a9c1490fa2647960bcb1ac4
This change is