LT-22298 Attempt 3: standardise base_build_number#498
Merged
Conversation
The variable `BaseBuildish` from Jenkins builds was inappropriately named, so it was renamed to `base_build_number` in most places. Update stragglers. Change-Id: I82f366ffa468379b57c149e80429570db1271ad0
Change-Id: I3d7c3ee04323dd3a32210a241e33e012a02967ef
Contributor
Author
|
FwBuildTasks Substitute is already replacing $BASEBUILDNUMBER with %BASE_BUILD_NUMBER%, but the patch workflow wasn't specifying that, so assemblies weren't getting stamped. |
jasonleenaylor
approved these changes
Oct 24, 2025
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @papeh)
papeh
added a commit
that referenced
this pull request
Nov 3, 2025
The variable `BaseBuildish` from Jenkins builds was inappropriately named, so it was renamed to `base_build_number` in most places. Update stragglers. * Include the Base Build Number in error reports
papeh
added a commit
that referenced
this pull request
Nov 3, 2025
LT-22298 Attempt 3: standardise base_build_number (cherry-pick of #498) The variable `BaseBuildish` from Jenkins builds was inappropriately named, so it was renamed to `base_build_number` in most places. Update stragglers. * Include the Base Build Number in error reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseBuildishfrom Jenkins builds was inappropriately named, so it was renamed tobase_build_numberin most places.Update stragglers.
This change is