Remove dead code#926
Merged
Merged
Conversation
This removal is part of the changes that were made in the PubSub branch with commit c6ec604.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused/obsolete refresh-related APIs and helper methods across xWorks/LexText/Common, aligning the branch with the PubSub cleanup referenced in the PR description.
Changes:
- Removed obsolete
RefreshAllViewsAPIs fromIApp,IFwMainWnd, and their former implementations/helpers (FwApp,FwXWindow). - Removed unused
RefreshAfterInvalidObjecthook fromRecordClerkand its Concordance override, plus other dead code/usings. - Minor modernizations to reduce noise (null-conditional calls/disposal, discard unused
outvalues, safer pattern matching cast).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Src/xWorks/RecordClerk.cs | Drops unused RootSites using, simplifies null-check calls, removes unused RefreshAfterInvalidObject hook. |
| Src/xWorks/FwXWindow.cs | Removes unused undo helper and obsolete RefreshAllViews method that forwarded "Refresh" messages. |
| Src/LexText/Morphology/PhEnvStrRepresentationSlice.cs | Removes unused ConstraintFailure local, uses discard and null-conditional dispose for WaitCursor. |
| Src/LexText/LexTextDll/LexTextApp.cs | Removes unused System.ComponentModel using. |
| Src/LexText/Interlinear/InterlinearTextsRecordClerk.cs | Replaces as + cast with is pattern matching for the concordance list refresh. |
| Src/LexText/Interlinear/ConcordanceControl.cs | Removes override of now-removed RefreshAfterInvalidObject. |
| Src/Common/RootSite/UndoActions.cs | Removes stale file header comment lines. |
| Src/Common/RootSite/IApp.cs | Removes RefreshAllViews() from the app interface. |
| Src/Common/Framework/IFwMainWnd.cs | Removes RefreshAllViews() from the main window interface. |
| Src/Common/Framework/FwApp.cs | Removes unused refresh suppression state and the RefreshAllViews() implementation. |
johnml1135
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removal is part of the changes that were made in the PubSub branch with commit c6ec604.
This change is