Phase-1 follow-up: Avalonia rule-formula editors (Grammar)#966
Draft
johnml1135 wants to merge 1 commit into
Draft
Phase-1 follow-up: Avalonia rule-formula editors (Grammar)#966johnml1135 wants to merge 1 commit into
johnml1135 wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
17bd535 to
5120ef6
Compare
johnml1135
force-pushed
the
phase1-followup-rule
branch
from
ace0238 to
9461891
Compare
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
5120ef6 to
3c5893e
Compare
johnml1135
force-pushed
the
phase1-followup-rule
branch
from
9461891 to
2c142bc
Compare
johnml1135
added a commit
that referenced
this pull request
Jul 3, 2026
Verified the stacked follow-up PRs this base PR's description promises actually exist and are correctly chained: phase1-followup-interlinear (#965) -> phase1-followup-rule (#966) -> phase1-followup-table (#967), all open/draft. The gating comments explaining why the browse table and ChorusNotesPlugin are inert said "a follow-up PR" generically -- name phase1-followup-table specifically (matching the sibling comment in LexicalEditSurfaceRegistry.cs, which already names avalonia-interlinear- editor/avalonia-rule-formula-editor per tool). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
3c5893e to
d6003e4
Compare
johnml1135
force-pushed
the
phase1-followup-rule
branch
2 times, most recently
from
b2d7965 to
712c610
Compare
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
d6003e4 to
c937d8b
Compare
johnml1135
force-pushed
the
phase1-followup-rule
branch
from
712c610 to
a81966e
Compare
Stacked on the interlinear follow-up. Restore the rule-formula surface and activate it: - add back the 29 rule-formula files (the 5 plugins, RuleFormulaModel/RegionEditor + RuleCellCommands, PhEnvironment + BasicIPASymbol editors, projector/sinks/options + deriver, and all their tests incl. SupportingEditorComposeTests) - restore the 5 plugin registrations in RegionEditorPlugins - restore the 5 rule class names in the burn-down census - FLIP: register the 6 rule tools (PhonologicalRuleEdit, EnvironmentEdit, compoundRuleAdvancedEdit, naturalClassedit, phonemeEdit, AdhocCoprohibEdit) in LexicalEditFeatureCatalog under a new "Grammar rule editors" group (restoring the canonical pre-split active set + parity notes); Phase1FollowUpSurfaceTools is now empty (both edit follow-ups landed; browse table gated separately) - add the 6 rule TestCase rows to RegisteredRecordEditTools_ResolveToAvalonia Rebased onto the squashed phase1-base (post PR #964 review): tool registration is now catalog-driven, so this flip also adds a new "Grammar rule editors" group (6 rows) to the Tools->Options "Manage Individual Features" dialog under UIMode=New. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
johnml1135
force-pushed
the
phase1-followup-rule
branch
from
a81966e to
2f81e91
Compare
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
c937d8b to
bebe347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase-1 follow-up: Avalonia rule-formula editors (Grammar)
Stacked on the interlinear follow-up. Restores and activates the Grammar rule-editor family.
RuleFormulaModel/RegionEditor/RuleCellCommands, projector/sinks/options/deriver, and all their tests.PhonologicalRuleEdit,EnvironmentEdit,compoundRuleAdvancedEdit,naturalClassedit,phonemeEdit,AdhocCoprohibEdit) inLexicalEditFeatureCatalogunder a new "Grammar rule editors" group (restoring the canonical pre-split active set + parity notes).Phase1FollowUpSurfaceToolsis now empty.Note: since this branch was rebased onto the squashed base PR, "flip" now means catalog entries rather than a hardcoded array edit — as a side effect, this also adds a new "Grammar rule editors" group (6 rows: Phonological Rules, Phonological Environments, Compound Rules, Natural Classes, Phonemes, Ad Hoc Co-occurrence Rules) to the Tools→Options "Manage Individual Features" dialog, visible under
UIMode=New.Verification: build green; census + 6 rule
RegisteredRecordEditToolscases + RuleFormula/SupportingEditorCompose suites all passing (FwAvaloniaTests866/866,xWorksTests1695/1697, 2 pre-existing skips).This change is