Raise default Chorus local-op timeout so large projects can Send/Receive#359
Closed
myieye wants to merge 1 commit into
Closed
Raise default Chorus local-op timeout so large projects can Send/Receive#359myieye wants to merge 1 commit into
myieye wants to merge 1 commit into
Conversation
Chorus's 15-minute default timeout on local hg operations (e.g. the post-merge commit) is too short for very large projects, which then land on hold with a TimeoutException (#357). Default CHORUS_LOCAL_TIMEOUT_SECONDS to 1800 in environ, and pass it through both lfmergeqm launch scripts' sudo --preserve-env so a deployment can override it for larger projects. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
myieye
force-pushed
the
document-chorus-timeout-env
branch
from
cbef4a1 to
23e9437
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chorus's default 15-minute timeout on local hg operations (notably the post-merge
hg commit) is too short for very large projects: the commit runs past 900s and the project lands on hold with aTimeoutException. This recurs for at least one production project (#357), where a maintainer has had to hand-editenvironon the live container — which is wiped on every redeploy.This bakes the fix into the image:
environ: defaultCHORUS_LOCAL_TIMEOUT_SECONDSto 1800 (30 min) via${VAR:-1800}— a conservative default that a deployment can raise as needed.lfmergeqm-background.sh/lfmergeqm-looping.sh: addCHORUS_LOCAL_TIMEOUT_SECONDSto thesudo --preserve-envlist, so a deployment-supplied value survives the privilege drop towww-dataand overrides the default. Without this, an env var set on the container is stripped by sudo and never reaches Chorus.Closes #357.