Enhance refMatch functionality to support same verse letter ranges and improve test coverage for edge cases. Added tests for valid and invalid letter suffix scenarios.

Author: Greg Trihus

src/renderer/src/__tests__/refMatch.test.ts

@@ -79,8 +79,16 @@ test('shoulc fail with beg with letter < end with letter, 1:1b-1a', () => {
   expect(refMatch('1:1b-1a')).toBeNull();
 });
 
-test('should fail with beg with letter < end as letter, 1:1b-c', () => {
-  expect(refMatch('1:1b-c')).toBeNull();
+test('same verse letter range 1:22a-b', () => {
+  expect(refMatch('1:22a-b')).not.toBeNull();
+});
+
+test('same verse letter range 1:1b-c', () => {
+  expect(refMatch('1:1b-c')).not.toBeNull();
+});
+
+test('should fail same verse letter range when end is before start, 1:1c-b', () => {
+  expect(refMatch('1:1c-b')).toBeNull();
 });
 
 test('should fail with beg as letter < end with letter, 1:b-2c', () => {

src/renderer/src/utils/refMatch.ts

@@ -10,6 +10,16 @@ export const refMatch = (ref: string): RegExpExecArray | null => {
     if (parseInt(arg3 || '0') !== parseInt(chapter || '0') + 1) return null;
     return m;
   } else if (arg3) {
+    // Same verse, letter-suffix range (e.g. 1:22a-b = verse 22, parts a through b).
+    const sameVerseLetterEnd =
+      /^[a-e]$/i.test(arg3) &&
+      /^(\d+)([a-e])$/i.exec(verseStart || '');
+    if (sameVerseLetterEnd) {
+      const [, , startLetter] = sameVerseLetterEnd;
+      const endLetter = arg3.toLowerCase();
+      if (endLetter <= startLetter.toLowerCase()) return null;
+      return m;
+    }
     const vBeg = parseInt(verseStart || '');
     const vEnd = parseInt(arg3 || '');
     if (Number.isNaN(vBeg) || Number.isNaN(vEnd)) return null;