Skip to content

Add commits order index #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myieye merged 3 commits into from
Jun 11, 2026
Merged

Add commits order index #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1aa44c
Add commits order index
myieye May 28, 2026
263927c
Bump EFCore.ComplexIndexes to 2.0.5
myieye Jun 3, 2026
bbf37e2
Bump EFCore.ComplexIndexes to 3.1.5 (#69)
myieye Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@
<PackageVersion Include="linq2db" Version="6.2.1" />
<PackageVersion Include="linq2db.EntityFrameworkCore" Version="10.3.0" />
<PackageVersion Include="linq2db.Extensions" Version="6.2.1" />
<PackageVersion Include="EFCore.ComplexIndexes" Version="3.1.5" />
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions src/SIL.Harmony.Tests/DbContextTests.VerifyModel.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
Keys:
Id PK
Annotations:
CustomIndex:CompositeIndexes: [{"paths":["HybridDateTime.DateTime","HybridDateTime.Counter","Id"],"unique":false,"name":"IX_Commits_DateTime_Counter_Id"}]
Relational:FunctionName:
Relational:Schema:
Relational:SqlQuery:
Expand Down
8 changes: 8 additions & 0 deletions src/SIL.Harmony/Db/EntityConfig/CommitEntityConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Text.Json;
using EFCore.ComplexIndexes;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Metadata.Builders;

Expand All @@ -21,6 +22,13 @@ public void Configure(EntityTypeBuilder<Commit> builder)
.HasColumnName("DateTime");
hybridEntity.Property(h => h.Counter).HasColumnName("Counter");
});
// Supports Harmony's DefaultOrder (ASC) directly and DefaultOrderDescending via reverse scan.
// EF Core 10 cannot express indexes mixing ComplexProperty members + scalars (efcore#11336, targeted for 11).
// We use EFCore.ComplexIndexes instead. Both Harmony sorts are uniform-direction, so a single
// ASC index covers both — SQLite and Postgres reverse-scan it for the descending case.
builder.HasComplexCompositeIndex(
c => new { c.HybridDateTime.DateTime, c.HybridDateTime.Counter, c.Id },
indexName: "IX_Commits_DateTime_Counter_Id");
Comment thread
myieye marked this conversation as resolved.
builder.Property(c => c.Metadata)
.HasColumnType("jsonb")
.HasConversion(
Expand Down
1 change: 1 addition & 0 deletions src/SIL.Harmony/SIL.Harmony.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" />
<PackageReference Include="EFCore.ComplexIndexes" />
<PackageReference Include="Nito.AsyncEx.Coordination" />
</ItemGroup>

Expand Down
Loading