-
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathProjectModals.test.tsx
More file actions
618 lines (572 loc) · 19.6 KB
/
ProjectModals.test.tsx
File metadata and controls
618 lines (572 loc) · 19.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
/** @file Unit tests for ProjectModals. */
/// <reference types="jest" />
/// <reference types="@testing-library/jest-dom" />
import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { makeWebViewState } from '../test-helpers';
import type { ModalState } from '../../components/ProjectModals';
import ProjectModals from '../../components/ProjectModals';
import type { InterlinearProjectSummary } from '../../types/interlinear-project-summary';
/** Minimal project summary used in tests. */
const MOCK_PROJECT: InterlinearProjectSummary = {
id: 'proj-1',
createdAt: '2026-01-01T00:00:00Z',
sourceProjectId: 'source-proj',
analysisLanguages: ['en'],
name: 'My Project',
};
const MOCK_PROJECT_2: InterlinearProjectSummary = {
id: 'proj-2',
createdAt: '2026-02-01T00:00:00Z',
sourceProjectId: 'source-proj',
analysisLanguages: ['fr'],
name: 'French Project',
};
jest.mock('../../components/SelectInterlinearProjectModal', () => ({
__esModule: true,
SelectInterlinearProjectModal: ({
onSelect,
onCreateNew,
onClose,
onViewInfo,
}: {
onSelect: (p: InterlinearProjectSummary) => void;
onCreateNew: () => void;
onClose: () => void;
onViewInfo: (p: InterlinearProjectSummary) => void;
}) => (
<div data-testid="select-modal">
<button type="button" data-testid="select-select" onClick={() => onSelect(MOCK_PROJECT)}>
Select
</button>
<button type="button" data-testid="select-select-2" onClick={() => onSelect(MOCK_PROJECT_2)}>
Select 2
</button>
<button type="button" data-testid="select-create-new" onClick={onCreateNew}>
Create new
</button>
<button type="button" data-testid="select-close" onClick={onClose}>
Close
</button>
<button type="button" data-testid="select-view-info" onClick={() => onViewInfo(MOCK_PROJECT)}>
View info
</button>
<button
type="button"
data-testid="select-view-info-2"
onClick={() => onViewInfo(MOCK_PROJECT_2)}
>
View info 2
</button>
</div>
),
}));
jest.mock('../../components/CreateProjectModal', () => ({
__esModule: true,
CreateProjectModal: ({
onClose,
onProjectCreated,
}: {
onClose: () => void;
onProjectCreated: (p: InterlinearProjectSummary) => void;
}) => (
<div data-testid="create-modal">
<button type="button" data-testid="create-close" onClick={onClose}>
Close
</button>
<button
type="button"
data-testid="create-created"
onClick={() => {
onProjectCreated(MOCK_PROJECT);
onClose();
}}
>
Created
</button>
</div>
),
}));
jest.mock('../../components/ProjectMetadataModal', () => ({
__esModule: true,
ProjectMetadataModal: ({
onClose,
onProjectSaved,
onProjectDeleted,
}: {
onClose: () => void;
onProjectSaved: (u: {
name?: string;
description?: string;
analysisLanguages: string[];
}) => void;
onProjectDeleted: (id: string) => void;
}) => (
<div data-testid="metadata-modal">
<button type="button" data-testid="metadata-close" onClick={onClose}>
Close
</button>
<button
type="button"
data-testid="metadata-save"
onClick={() => {
onProjectSaved({ name: 'Updated', analysisLanguages: ['fr'] });
onClose();
}}
>
Save
</button>
<button
type="button"
data-testid="metadata-delete"
onClick={() => {
onProjectDeleted(MOCK_PROJECT.id);
onClose();
}}
>
Delete
</button>
<button
type="button"
data-testid="metadata-delete-2"
onClick={() => {
onProjectDeleted(MOCK_PROJECT_2.id);
onClose();
}}
>
Delete 2
</button>
</div>
),
}));
/**
* Renders ProjectModals with sensible defaults and returns helpers for assertions.
*
* @param overrides - Partial props to merge over the defaults. Supports `activeProject`, `modal`
* (defaults to `'none'`), `setModal` (defaults to a fresh `jest.fn()`), and `useWebViewState`
* (defaults to a fresh {@link makeWebViewState} instance).
* @returns An object containing `setModal` — either the caller-supplied function or the internally
* created `jest.fn()` — so callers can assert on it after interactions.
*/
function renderModals(
overrides: Partial<{
activeProject: InterlinearProjectSummary | undefined;
modal: ModalState;
setModal: (m: ModalState) => void;
useWebViewState: ReturnType<typeof makeWebViewState>;
}> = {},
) {
const setModal = overrides.setModal ?? jest.fn();
const useWebViewState = overrides.useWebViewState ?? makeWebViewState();
render(
<ProjectModals
activeProject={overrides.activeProject}
modal={overrides.modal ?? 'none'}
projectId="source-proj"
setModal={setModal}
useWebViewState={useWebViewState}
/>,
);
return { setModal };
}
describe('ProjectModals', () => {
describe('modal visibility', () => {
it('renders nothing when modal is none', () => {
const { container } = render(
<ProjectModals
activeProject={undefined}
modal="none"
projectId="source-proj"
setModal={jest.fn()}
useWebViewState={makeWebViewState()}
/>,
);
expect(container.querySelector('[data-testid]')).toBeNull();
});
it('renders the select modal when modal is select', () => {
renderModals({ modal: 'select' });
expect(screen.getByTestId('select-modal')).toBeInTheDocument();
});
it('renders the create modal when modal is create', () => {
renderModals({ modal: 'create' });
expect(screen.getByTestId('create-modal')).toBeInTheDocument();
});
it('renders the metadata modal when modal is metadata and activeProject is set', () => {
renderModals({ modal: 'metadata', activeProject: MOCK_PROJECT });
expect(screen.getByTestId('metadata-modal')).toBeInTheDocument();
});
it('renders nothing when modal is metadata but no active or metadata project', () => {
const { container } = render(
<ProjectModals
activeProject={undefined}
modal="metadata"
projectId="source-proj"
setModal={jest.fn()}
useWebViewState={makeWebViewState()}
/>,
);
expect(container.querySelector('[data-testid="metadata-modal"]')).toBeNull();
});
});
describe('select modal', () => {
it('calls setModal with none when select modal close is clicked', async () => {
const { setModal } = renderModals({ modal: 'select' });
await userEvent.click(screen.getByTestId('select-close'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('sets the active project and calls setModal with none when a project is selected', async () => {
const state = makeWebViewState();
const { setModal } = renderModals({ modal: 'select', useWebViewState: state });
await userEvent.click(screen.getByTestId('select-select'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('calls setModal with create when create new is clicked', async () => {
const { setModal } = renderModals({ modal: 'select' });
await userEvent.click(screen.getByTestId('select-create-new'));
expect(setModal).toHaveBeenCalledWith('create');
});
it('opens metadata modal for the chosen project when view info is clicked', async () => {
const { setModal } = renderModals({ modal: 'select' });
await userEvent.click(screen.getByTestId('select-view-info'));
expect(setModal).toHaveBeenCalledWith('metadata');
});
});
describe('create modal', () => {
it('calls setModal with none when create modal is closed without a select source', async () => {
const { setModal } = renderModals({ modal: 'create' });
await userEvent.click(screen.getByTestId('create-close'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('calls setModal with select on close when opened from the select modal', async () => {
const setModal = jest.fn();
const state = makeWebViewState();
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-create-new'));
rerender(
<ProjectModals
activeProject={undefined}
modal="create"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
setModal.mockClear();
await userEvent.click(screen.getByTestId('create-close'));
expect(setModal).toHaveBeenCalledWith('select');
});
it('resets createSourceIsSelect after closing from select source', async () => {
const setModal = jest.fn();
const state = makeWebViewState();
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-create-new'));
rerender(
<ProjectModals
activeProject={undefined}
modal="create"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('create-close'));
// After close, setModal returns to 'select'. If we re-render with create again,
// closing this time should go to 'none' (select source was reset).
setModal.mockClear();
rerender(
<ProjectModals
activeProject={undefined}
modal="create"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('create-close'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('sets the active project and calls setModal with none when a project is created', async () => {
const state = makeWebViewState();
const { setModal } = renderModals({ modal: 'create', useWebViewState: state });
await userEvent.click(screen.getByTestId('create-created'));
expect(setModal).toHaveBeenCalledWith('none');
});
});
describe('metadata modal', () => {
it('calls setModal with none when metadata modal closes without a select source', async () => {
const { setModal } = renderModals({ modal: 'metadata', activeProject: MOCK_PROJECT });
await userEvent.click(screen.getByTestId('metadata-close'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('calls setModal with select on close when metadataSourceIsSelect is true', async () => {
const setModal = jest.fn();
const state = makeWebViewState();
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-view-info'));
rerender(
<ProjectModals
activeProject={undefined}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
setModal.mockClear();
await userEvent.click(screen.getByTestId('metadata-close'));
expect(setModal).toHaveBeenCalledWith('select');
});
it('resets metadataSourceIsSelect after closing from select source', async () => {
const setModal = jest.fn();
const state = makeWebViewState();
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-view-info'));
rerender(
<ProjectModals
activeProject={undefined}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('metadata-close'));
// After close, setModal returns to 'select'. If we re-render with metadata again,
// closing this time should go to 'none' (select source was reset).
setModal.mockClear();
rerender(
<ProjectModals
activeProject={MOCK_PROJECT}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('metadata-close'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('updates activeProject when the saved project matches the active project', async () => {
const state = makeWebViewState();
// Set active project first via select modal
const setModal = jest.fn();
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-select'));
// Re-render with metadata open and activeProject as MOCK_PROJECT
rerender(
<ProjectModals
activeProject={MOCK_PROJECT}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('metadata-save'));
// Saving should call setModal with none and update the active project (no error)
expect(setModal).toHaveBeenCalledWith('none');
});
it('does not update activeProject when the saved project does not match the active project', async () => {
const state = makeWebViewState();
const setModal = jest.fn();
// Open select, choose project 1 as active, then view info for project 2
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-select'));
await userEvent.click(screen.getByTestId('select-view-info-2'));
rerender(
<ProjectModals
activeProject={MOCK_PROJECT}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
// Saving project 2 — onProjectSaved is called but activeProject (proj-1) ≠ metadataProject (proj-2)
await userEvent.click(screen.getByTestId('metadata-save'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('does not update activeProject when there is no active project on save', async () => {
const setModal = jest.fn();
const state = makeWebViewState();
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-view-info'));
rerender(
<ProjectModals
activeProject={undefined}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
setModal.mockClear();
await userEvent.click(screen.getByTestId('metadata-save'));
// Metadata was opened from select, so close returns to select (not none)
expect(setModal).toHaveBeenCalledWith('select');
});
it('resets the active project when the deleted project matches the active project', async () => {
const state = makeWebViewState();
const setModal = jest.fn();
// Set MOCK_PROJECT as active via select, then open metadata
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-select'));
rerender(
<ProjectModals
activeProject={MOCK_PROJECT}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('metadata-delete'));
expect(setModal).toHaveBeenCalledWith('none');
});
it('does not reset the active project when the deleted project does not match', async () => {
const state = makeWebViewState();
const setModal = jest.fn();
const { rerender } = render(
<ProjectModals
activeProject={MOCK_PROJECT}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-view-info-2'));
rerender(
<ProjectModals
activeProject={MOCK_PROJECT}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
setModal.mockClear();
// Delete proj-2, but active is proj-1 — should not reset active project
await userEvent.click(screen.getByTestId('metadata-delete-2'));
// Opened from select, so close returns to select
expect(setModal).toHaveBeenCalledWith('select');
});
it('does not reset the active project when there is no active project on delete', async () => {
const state = makeWebViewState();
const setModal = jest.fn();
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-view-info'));
rerender(
<ProjectModals
activeProject={undefined}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
setModal.mockClear();
await userEvent.click(screen.getByTestId('metadata-delete'));
// Opened from select, so close returns to select
expect(setModal).toHaveBeenCalledWith('select');
});
it('uses metadataProject over activeProject when both are set', async () => {
const setModal = jest.fn();
const state = makeWebViewState();
// Open select, view info for proj-2 (sets metadataProject=proj-2)
const { rerender } = render(
<ProjectModals
activeProject={undefined}
modal="select"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
await userEvent.click(screen.getByTestId('select-view-info-2'));
rerender(
<ProjectModals
activeProject={MOCK_PROJECT}
modal="metadata"
projectId="source-proj"
setModal={setModal}
useWebViewState={state}
/>,
);
// Metadata modal is visible — it uses metadataProject (proj-2), not activeProject (proj-1)
expect(screen.getByTestId('metadata-modal')).toBeInTheDocument();
});
});
});