Throw on malformed createProject response instead of silently skipping onProjectCreated

Previously, if the backend returned a JSON object that failed isInterlinearProjectSummary, the modal would call onClose() without invoking onProjectCreated, silently dropping the contract. Now it throws, routing through the existing error handler. Also fixes an incomplete fixture in the success test that was missing required summary fields.

Author: alex-rawlings-yyc

src/__tests__/components/CreateProjectModal.test.tsx

@@ -100,11 +100,14 @@ describe('CreateProjectModal', () => {
   });
 
   it('calls onClose after submitting when sendCommand returns a project JSON', async () => {
-    jest
-      .mocked(papi.commands.sendCommand)
-      .mockResolvedValue(
-        JSON.stringify({ id: 'new-project-id', createdAt: '2026-01-01T00:00:00.000Z' }),
-      );
+    jest.mocked(papi.commands.sendCommand).mockResolvedValue(
+      JSON.stringify({
+        id: 'new-project-id',
+        createdAt: '2026-01-01T00:00:00.000Z',
+        sourceProjectId: testProjectId,
+        analysisWritingSystem: 'en',
+      }),
+    );
     const onClose = jest.fn();
     render(<CreateProjectModal projectId={testProjectId} onClose={onClose} />);
 
@@ -145,6 +148,29 @@ describe('CreateProjectModal', () => {
     );
   });
 
+  it('does not call onProjectCreated or onClose and sends an error notification when sendCommand returns malformed JSON', async () => {
+    jest.mocked(papi.commands.sendCommand).mockResolvedValue(JSON.stringify({ bad: 'shape' }));
+    const onProjectCreated = jest.fn();
+    const onClose = jest.fn();
+    render(
+      <CreateProjectModal
+        projectId={testProjectId}
+        onClose={onClose}
+        onProjectCreated={onProjectCreated}
+      />,
+    );
+
+    await userEvent.click(screen.getByRole('button', { name: /^create$/i }));
+
+    await waitFor(() =>
+      expect(papi.notifications.send).toHaveBeenCalledWith(
+        expect.objectContaining({ severity: 'error' }),
+      ),
+    );
+    expect(onProjectCreated).not.toHaveBeenCalled();
+    expect(onClose).not.toHaveBeenCalled();
+  });
+
   it('does not call onProjectCreated or onClose when sendCommand returns undefined', async () => {
     jest.mocked(papi.commands.sendCommand).mockResolvedValue(undefined);
     const onProjectCreated = jest.fn();

src/components/CreateProjectModal.tsx

@@ -71,7 +71,9 @@ export function CreateProjectModal({
       );
       if (!projectJson) return;
       const parsed: unknown = JSON.parse(projectJson);
-      if (isInterlinearProjectSummary(parsed)) onProjectCreated?.(parsed);
+      if (!isInterlinearProjectSummary(parsed))
+        throw new Error('Created project has unexpected shape');
+      onProjectCreated?.(parsed);
       onClose();
     } catch (e) {
       logger.error('Interlinearizer: failed to create project', e);