sillsdev
diff --git a/‎.github/workflows/lint.yml‎
Lines changed: 3 additions & 1 deletion b/‎.github/workflows/lint.yml‎
Lines changed: 3 additions & 1 deletion
diff --git a/‎.vscode/settings.json‎
Lines changed: 3 additions & 0 deletions b/‎.vscode/settings.json‎
Lines changed: 3 additions & 0 deletions
diff --git a/‎AGENTS.md‎
Lines changed: 12 additions & 2 deletions b/‎AGENTS.md‎
Lines changed: 12 additions & 2 deletions
diff --git a/‎REVIEW.md‎
Lines changed: 25 additions & 0 deletions b/‎REVIEW.md‎
Lines changed: 25 additions & 0 deletions
diff --git a/‎__mocks__/lucide-react.tsx‎
Lines changed: 40 additions & 0 deletions b/‎__mocks__/lucide-react.tsx‎
Lines changed: 40 additions & 0 deletions
diff --git a/‎__mocks__/papi-frontend-react.ts‎
Lines changed: 1 addition & 1 deletion b/‎__mocks__/papi-frontend-react.ts‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎__mocks__/platform-bible-react.tsx‎
Lines changed: 45 additions & 23 deletions b/‎__mocks__/platform-bible-react.tsx‎
Lines changed: 45 additions & 23 deletions
diff --git a/‎contributions/localizedStrings.json‎
Lines changed: 8 additions & 1 deletion b/‎contributions/localizedStrings.json‎
Lines changed: 8 additions & 1 deletion
diff --git a/‎contributions/projectSettings.json‎
Lines changed: 10 additions & 0 deletions b/‎contributions/projectSettings.json‎
Lines changed: 10 additions & 0 deletions
diff --git a/‎cspell.json‎
Lines changed: 22 additions & 30 deletions b/‎cspell.json‎
Lines changed: 22 additions & 30 deletions
@@ -40,7 +40,9 @@ jobs:
 
       - name: Install extension dependencies
         working-directory: extension-repo
-        run: npm ci --ignore-scripts --omit=optional
+        # Cannot --omit=optional: @swc/core and lightningcss ship native binaries as optional deps
+        # required by the build toolchain (SWC for transpilation, lightningcss for Tailwind CSS).
+        run: npm ci --ignore-scripts
 
       - name: Install core dependencies
         working-directory: paranext-core
 
@@ -1,12 +1,15 @@
 {
   "css.customData": [".vscode/tailwindcss.json"],
+  "css.validate": false,
 
   "editor.defaultFormatter": "esbenp.prettier-vscode",
   "editor.formatOnSave": true,
   "editor.rulers": [100],
   "editor.wordWrapColumn": 100,
 
   "eslint.validate": ["html", "javascript", "javascriptreact", "typescript", "typescriptreact"],
+  "stylelint.validate": ["css", "less", "postcss", "scss", "tailwindcss"],
+  "tailwindCSS.validate": false,
 
   "files.associations": {
     "*.css": "tailwindcss",
 
@@ -1,6 +1,8 @@
 # AGENTS.md
 
-This file provides guidance to AI agents when working with code in this repository.
+This file provides guidance to AI agents creating and editing code in this repository.
+
+Agents **reviewing** code should also read [REVIEW.md](REVIEW.md), which documents existing conventions that commonly trigger false-positive findings.
 
 ## Commands
 
@@ -143,7 +145,15 @@ Every function and method — exported or internal — must have a JSDoc block w
 - `@returns` describing the return value (omit only for `void`/`Promise<void>`).
 - `@throws` for every error condition the caller must handle; omit if the function never throws.
 
-Type declarations (interfaces, type aliases, enums) must have a JSDoc summary on the type itself and on each field or member whose purpose is not self-evident from its name and type.
+Type declarations (interfaces, type aliases, enums) must have a JSDoc summary on the type itself and on each field or member whose purpose is not self-evident from its name and type. We document each field individually rather than describing the fields in the type-level summary.
+
+## Spelling
+
+Use American English throughout — in code, comments, JSDoc, and documentation:
+
+- `center` not `centre`, `color` not `colour`, `behavior` not `behaviour`
+- `canceled`/`canceling` not `cancelled`/`cancelling`, `leveled`/`leveling` not `levelled`/`levelling`
+- `neighboring` not `neighbouring`, `favor` not `favour`, `signaled` not `signalled`
 
 ## UX decisions
 
 
@@ -0,0 +1,25 @@
+# REVIEW.md
+
+This file provides guidance to AI agents **reviewing** code in this repository. It documents existing conventions that commonly trigger false-positive findings, so reviewers don't flag intentional, already-handled patterns as issues.
+
+Agents creating or editing code should follow [AGENTS.md](AGENTS.md); this file is supplementary and review-specific.
+
+## Tailwind v4 at-rules
+
+Tailwind v4 at-rules (`@utility`, `@apply`, `@theme`, `@config`, `@custom-variant`, `@layer`, `@source`, `@plugin`, etc.) are **already whitelisted** in [.stylelintrc.js](.stylelintrc.js)'s `scss/at-rule-no-unknown` `ignoreAtRules` list. Do **not** flag these as Stylelint violations, and do not suggest adding them to the config or adding `stylelint-disable` comments — they already pass. If you believe a lint rule is firing, run `npm run lint` and cite the actual output rather than inferring it from the rule name.
+
+## Documentation completeness
+
+Type declarations document each field individually rather than describing the fields in the type-level summary. When each field already carries its own JSDoc comment, the documentation is **complete** — do not flag it as inadequate, and do not ask for per-field details to be repeated or summarized in the type-level doc. The type-level summary describes the type as a whole; the per-field comments describe the fields. Only flag a field that is genuinely missing its own comment.
+
+Before reporting any documentation as missing, open the file and confirm the JSDoc is actually absent. Do not infer missing docs from a symbol name, a type signature, or an excerpt — read the declaration.
+
+## Keyboard navigation
+
+Keyboard accessibility is planned but not yet implemented. Do not flag missing `tabIndex` attributes, absent `aria-*` roles, or gaps in focus management as issues — these will be addressed in a dedicated pass once the core interaction model is stable.
+
+## Mock cleanup in tests
+
+[jest.config.ts](jest.config.ts) sets both `resetMocks: true` and `restoreMocks: true`. This means every `jest.spyOn(...)` is automatically restored to its original implementation after each test — tests do **not** need a manual `mockRestore()` or `jest.restoreAllMocks()` in `afterEach` for spies. Do not flag spies as leaking or suggest adding cleanup for them.
+
+Manual cleanup in `afterEach` is only required for state that `restoreMocks` cannot undo, such as plain reassignment of a global (e.g. `global.ResizeObserver = ...`). When you see an `afterEach` restoring only some things, confirm whether the rest are spies (auto-restored) before flagging an omission.
@@ -34,3 +34,43 @@ export function Info(props: Readonly<{ size?: number; className?: string }>): Re
 export function Trash2(props: Readonly<{ size?: number; className?: string }>): ReactElement {
   return <svg data-testid="trash2-icon" {...props} />;
 }
+
+/**
+ * Stub for the X icon.
+ *
+ * @param props - SVG props forwarded from the component.
+ * @returns A ReactElement SVG element used as an X icon stub in tests.
+ */
+export function X(props: Readonly<{ size?: number; className?: string }>): ReactElement {
+  return <svg data-testid="x-icon" {...props} />;
+}
+
+/**
+ * Stub for the Link2 (link) icon used by the between-token link button.
+ *
+ * @param props - SVG props forwarded from the component.
+ * @returns A ReactElement SVG element used as a link icon stub in tests.
+ */
+export function Link2(props: Readonly<{ size?: number; className?: string }>): ReactElement {
+  return <svg data-testid="link2-icon" {...props} />;
+}
+
+/**
+ * Stub for the Link2Off (unlink) icon used by the between-token unlink and arc-split buttons.
+ *
+ * @param props - SVG props forwarded from the component.
+ * @returns A ReactElement SVG element used as an unlink icon stub in tests.
+ */
+export function Link2Off(props: Readonly<{ size?: number; className?: string }>): ReactElement {
+  return <svg data-testid="link2off-icon" {...props} />;
+}
+
+/**
+ * Stub for the Settings gear icon used by the view-options dropdown button.
+ *
+ * @param props - SVG props forwarded from the component.
+ * @returns A ReactElement SVG element used as a settings icon stub in tests.
+ */
+export function Settings(props: Readonly<{ size?: number; className?: string }>): ReactElement {
+  return <svg data-testid="settings-icon" {...props} />;
+}
@@ -6,7 +6,7 @@
 /**
  * Known data-provider method names exposed by this mock. Tests that call an unlisted method will
  * receive a descriptive error rather than silently returning `undefined`, which mirrors the real
- * PAPI behaviour where requesting an unsupported provider key is a programmer error.
+ * PAPI behavior where requesting an unsupported provider key is a programmer error.
  */
 const KNOWN_PROJECT_DATA_METHODS = new Set(['BookUSJ']);
 
 
@@ -3,6 +3,7 @@
  * without extra transform configuration. This stub provides the subset used by the extension.
  */
 
+import { forwardRef } from 'react';
 import type { ReactElement, ReactNode } from 'react';
 
 export interface MenuItemContainingCommand {
@@ -188,8 +189,8 @@ export function ScrollGroupSelector({
 
 /**
  * Stub button that passes through `children`, `onClick`, `type`, `className`, `disabled`,
- * `aria-label`, and forwards them to a native `<button>` element; `variant` and `size` are
- * accepted but ignored.
+ * `aria-label`, `aria-expanded`, `aria-haspopup`, `data-testid`, and `ref` to a native `<button>`
+ * element; `variant` and `size` are accepted but ignored.
  *
  * @param props - Component props.
  * @param props.children - Button content.
@@ -199,39 +200,60 @@ export function ScrollGroupSelector({
  * @param props.disabled - Whether the button is disabled.
  * @param props.variant - Ignored styling variant.
  * @param props.size - Ignored size variant.
- * @returns A native `<button>` element with `aria-label` forwarded.
+ * @param props['aria-label'] - Accessible label.
+ * @param props['aria-expanded'] - Expanded state for popup triggers.
+ * @param props['aria-haspopup'] - Haspopup attribute.
+ * @param props['data-testid'] - Test identifier.
+ * @param ref - Forwarded ref to the underlying button element.
+ * @returns A native `<button>` element with standard attributes forwarded.
  */
-export function Button({
-  children,
-  onClick,
-  type,
-  className,
-  disabled,
-  variant: _variant,
-  size: _size,
-  'aria-label': ariaLabel,
-}: Readonly<{
-  children?: ReactNode;
-  onClick?: () => void;
-  type?: 'button' | 'submit' | 'reset';
-  className?: string;
-  disabled?: boolean;
-  variant?: 'default' | 'secondary' | 'destructive' | 'ghost' | 'outline' | 'link';
-  size?: 'default' | 'sm' | 'lg' | 'icon';
-  'aria-label'?: string;
-}>): ReactElement {
+export const Button = forwardRef<
+  HTMLButtonElement,
+  Readonly<{
+    children?: ReactNode;
+    onClick?: () => void;
+    type?: 'button' | 'submit' | 'reset';
+    className?: string;
+    disabled?: boolean;
+    variant?: 'default' | 'secondary' | 'destructive' | 'ghost' | 'outline' | 'link';
+    size?: 'default' | 'sm' | 'lg' | 'icon';
+    'aria-label'?: string;
+    'aria-expanded'?: boolean;
+    'aria-haspopup'?: boolean | 'true' | 'false' | 'menu' | 'listbox' | 'tree' | 'grid' | 'dialog';
+    'data-testid'?: string;
+  }>
+>(function ButtonImpl(
+  {
+    children,
+    onClick,
+    type,
+    className,
+    disabled,
+    variant: _variant,
+    size: _size,
+    'aria-label': ariaLabel,
+    'aria-expanded': ariaExpanded,
+    'aria-haspopup': ariaHaspopup,
+    'data-testid': testId,
+  },
+  ref,
+) {
   return (
     <button
+      ref={ref}
       type={type ?? 'button'}
       onClick={onClick}
       className={className}
       aria-label={ariaLabel}
+      aria-expanded={ariaExpanded}
+      aria-haspopup={ariaHaspopup}
+      data-testid={testId}
       disabled={disabled}
     >
       {children}
     </button>
   );
-}
+});
 
 /**
  * Stub book/chapter control that displays the current reference as text and exposes a single
 
@@ -14,7 +14,14 @@
       "%interlinearizer_projectSettings_title%": "Interlinearizer",
       "%interlinearizer_projectSettings_continuousScroll%": "Continuous Scroll",
       "%interlinearizer_projectSettings_continuousScrollDescription%": "Display tokens in a continuous horizontal scroll strip instead of chapter-segmented rows",
-      "%interlinearizer_continuousScrollToggle%": "Continuous Scroll",
+      "%interlinearizer_viewOption_continuousScroll%": "Continuous Scroll",
+      "%interlinearizer_viewOption_hideInactiveLinkButtons%": "Hide out-of-segment link buttons",
+      "%interlinearizer_viewOption_simplifyPhrases%": "Show phrase controls on focus only",
+      "%interlinearizer_projectSettings_hideInactiveLinkButtons%": "Hide Out-of-Segment Link Buttons",
+      "%interlinearizer_projectSettings_hideInactiveLinkButtonsDescription%": "Hide link buttons between phrases in segments that are not currently active",
+      "%interlinearizer_projectSettings_simplifyPhrases%": "Show Phrase Controls on Focus Only",
+      "%interlinearizer_projectSettings_simplifyPhrasesDescription%": "Hide interactive controls (split, unlink, remove-token) on phrases that are not currently focused, leaving only their style change on hover",
+      "%interlinearizer_linkButton_crossSegmentDisabledTooltip%": "Cross-segment phrases are not supported. This link button is outside the current segment.",
 
       "%interlinearizer_modal_create_title%": "Create Interlinear Project",
       "%interlinearizer_modal_create_name_label%": "Name (optional)",
 
@@ -6,6 +6,16 @@
         "label": "%interlinearizer_projectSettings_continuousScroll%",
         "description": "%interlinearizer_projectSettings_continuousScrollDescription%",
         "default": true
+      },
+      "interlinearizer.hideInactiveLinkButtons": {
+        "label": "%interlinearizer_projectSettings_hideInactiveLinkButtons%",
+        "description": "%interlinearizer_projectSettings_hideInactiveLinkButtonsDescription%",
+        "default": false
+      },
+      "interlinearizer.simplifyPhrases": {
+        "label": "%interlinearizer_projectSettings_simplifyPhrases%",
+        "description": "%interlinearizer_projectSettings_simplifyPhrasesDescription%",
+        "default": false
       }
     }
   }
 
@@ -13,57 +13,48 @@
   "dictionaryDefinitions": [],
   "dictionaries": [],
   "words": [
+    "affordances",
     "appdata",
-    "asyncs",
-    "autodocs",
+    "bara",
     "BBCCCVVV",
-    "Discontiguous",
-    "dockbox",
+    "deconflict",
+    "deconfliction",
+    "deconflicts",
+    "discontig",
+    "discontiguous",
     "eflomal",
-    "electronmon",
+    "elohim",
     "endregion",
     "eten",
-    "finalizer",
-    "Fragmenter",
-    "guids",
-    "hopkinson",
+    "fontsource",
+    "hoverable",
     "iframes",
     "imte",
     "interlinearization",
     "interlinearize",
     "interlinearizer",
-    "interlinearizing",
+    "labelable",
     "lightningcss",
-    "localstorage",
-    "maximizable",
     "morphosyntactic",
-    "networkable",
-    "Newtonsoft",
-    "nodebuffer",
     "nums",
+    "okina",
     "papi",
-    "papis",
     "paranext",
     "paratext",
     "pdpf",
-    "pdps",
     "plusplus",
-    "proxied",
-    "Punct",
-    "recalc",
-    "reinitializing",
-    "reserialized",
+    "punct",
+    "relayout",
     "sandboxed",
     "scriptio",
+    "scrollers",
+    "shadcn",
     "sillsdev",
-    "steenwyk",
-    "stringifiable",
-    "Struc",
+    "struc",
     "Stylesheet",
     "typedefs",
-    "unanalyzed",
-    "unregistering",
-    "unregisters",
+    "unhover",
+    "unphrased",
     "unreviewed",
     "unsub",
     "unsubs",
@@ -72,8 +63,9 @@
     "usfm",
     "verseref",
     "versification",
-    "Wordform"
+    "wordform",
+    "ZWNJ"
   ],
-  "ignoreWords": [],
+  "ignoreWords": ["Ελληνικά", "homme", "ʼelohim", "ʻokina"],
   "import": []
 }
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,16 @@`
`6`	`6`	`"label": "%interlinearizer_projectSettings_continuousScroll%",`
`7`	`7`	`"description": "%interlinearizer_projectSettings_continuousScrollDescription%",`
`8`	`8`	`"default": true`
	`9`	`+ },`
	`10`	`+ "interlinearizer.hideInactiveLinkButtons": {`
	`11`	`+ "label": "%interlinearizer_projectSettings_hideInactiveLinkButtons%",`
	`12`	`+ "description": "%interlinearizer_projectSettings_hideInactiveLinkButtonsDescription%",`
	`13`	`+ "default": false`
	`14`	`+ },`
	`15`	`+ "interlinearizer.simplifyPhrases": {`
	`16`	`+ "label": "%interlinearizer_projectSettings_simplifyPhrases%",`
	`17`	`+ "description": "%interlinearizer_projectSettings_simplifyPhrasesDescription%",`
	`18`	`+ "default": false`
`9`	`19`	`}`
`10`	`20`	`}`
`11`	`21`	`}`