Fix analysis language default, button state, and storage error propagation

- Default analysis language to "und" (undetermined) instead of "en"
- Normalize whitespace-only language input to "und" on submit
- Disable the create button while submission is in progress
- Rethrow storage errors in getProjectsForSource so callers can distinguish an outage from an empty list

Author: alex-rawlings-yyc

src/__tests__/components/CreateProjectModal.test.tsx

@@ -55,7 +55,7 @@ describe('CreateProjectModal', () => {
       expect(papi.commands.sendCommand).toHaveBeenCalledWith(
         'interlinearizer.createProject',
         testProjectId,
-        'en',
+        'und',
         undefined,
         undefined,
       ),
@@ -73,7 +73,7 @@ describe('CreateProjectModal', () => {
       expect(papi.commands.sendCommand).toHaveBeenCalledWith(
         'interlinearizer.createProject',
         testProjectId,
-        'en',
+        'und',
         'My Project',
         'My Desc',
       ),
@@ -164,6 +164,44 @@ describe('CreateProjectModal', () => {
     expect(onClose).not.toHaveBeenCalled();
   });
 
+  it('defaults analysis language to "und" when the language input contains only whitespace', async () => {
+    render(<CreateProjectModal projectId={testProjectId} onClose={() => {}} />);
+
+    const languageInput = screen.getByLabelText(/analysis language/i);
+    await userEvent.clear(languageInput);
+    await userEvent.type(languageInput, '   ');
+    await userEvent.click(screen.getByRole('button', { name: /^create$/i }));
+
+    await waitFor(() =>
+      expect(papi.commands.sendCommand).toHaveBeenCalledWith(
+        'interlinearizer.createProject',
+        testProjectId,
+        'und',
+        undefined,
+        undefined,
+      ),
+    );
+  });
+
+  it('disables the create button while a submission is in progress', async () => {
+    let resolveCommand: (value: undefined) => void = () => {};
+    jest.mocked(papi.commands.sendCommand).mockImplementation(
+      () =>
+        new Promise((resolve) => {
+          resolveCommand = resolve;
+        }),
+    );
+    render(<CreateProjectModal projectId={testProjectId} onClose={() => {}} />);
+
+    const createButton = screen.getByRole('button', { name: /^create$/i });
+    await userEvent.click(createButton);
+
+    expect(createButton).toBeDisabled();
+    resolveCommand(undefined);
+
+    await waitFor(() => expect(createButton).not.toBeDisabled());
+  });
+
   it('does not call onClose or onProjectCreated when sendCommand rejects, but sends an error notification', async () => {
     jest.mocked(papi.commands.sendCommand).mockRejectedValue(new Error('network error'));
     const onProjectCreated = jest.fn();

src/__tests__/main.test.ts

@@ -761,13 +761,11 @@ describe('main', () => {
       expect(result).toBe(JSON.stringify([stubProject]));
     });
 
-    it('returns "[]" and logs an error when storage throws', async () => {
+    it('throws and logs an error when storage throws', async () => {
       mockGetProjectsForSource.mockRejectedValue(new Error('disk full'));
       const handler = await getProjectsForSourceHandler();
 
-      const result = await handler('src-project');
-
-      expect(result).toBe('[]');
+      await expect(handler('src-project')).rejects.toThrow('disk full');
       expect(__mockLogger.error).toHaveBeenCalledWith(
         'Interlinearizer: failed to list projects for source',
         expect.any(Error),

src/components/CreateProjectModal.tsx

@@ -48,7 +48,8 @@ export function CreateProjectModal({
 
   const [name, setName] = useState('');
   const [description, setDescription] = useState('');
-  const [analysisLanguage, setAnalysisLanguage] = useState('en');
+  const [analysisLanguage, setAnalysisLanguage] = useState('und');
+  const [isSubmitting, setIsSubmitting] = useState(false);
 
   /**
    * Sends the `interlinearizer.createProject` command with the collected form values, notifies the
@@ -58,11 +59,13 @@ export function CreateProjectModal({
    * @returns A promise that resolves when the command completes or the error notification is sent.
    */
   const handleSubmit = useCallback(async () => {
+    setIsSubmitting(true);
+    const normalizedAnalysisLanguage = analysisLanguage.trim() || 'und';
     try {
       const projectJson = await papi.commands.sendCommand(
         'interlinearizer.createProject',
         projectId,
-        analysisLanguage,
+        normalizedAnalysisLanguage,
         name || undefined,
         description || undefined,
       );
@@ -75,6 +78,8 @@ export function CreateProjectModal({
       await papi.notifications
         .send({ message: '%interlinearizer_error_create_project_failed%', severity: 'error' })
         .catch(() => {});
+    } finally {
+      setIsSubmitting(false);
     }
   }, [projectId, analysisLanguage, name, description, onClose, onProjectCreated]);
 
@@ -125,7 +130,7 @@ export function CreateProjectModal({
           <Button variant="secondary" onClick={onClose}>
             {localizedStrings['%interlinearizer_modal_create_cancel%']}
           </Button>
-          <Button onClick={handleSubmit}>
+          <Button onClick={handleSubmit} disabled={isSubmitting}>
             {localizedStrings['%interlinearizer_modal_create_submit%']}
           </Button>
         </div>

src/main.ts

@@ -212,15 +212,17 @@ async function updateProjectMetadata(
  * "select existing" when the user opens the project menu.
  *
  * @param sourceProjectId - Platform.Bible project ID of the source text to query.
- * @returns A JSON string of `InterlinearProject[]`, or `"[]"` if none exist or storage fails.
+ * @returns A JSON string of `InterlinearProject[]`, or `"[]"` if none exist.
+ * @throws The storage error when the underlying read fails, so callers can distinguish an outage
+ *   from an empty list.
  */
 async function getProjectsForSource(sourceProjectId: string): Promise<string> {
   try {
     const projects = await projectStorage.getProjectsForSource(executionToken, sourceProjectId);
     return JSON.stringify(projects);
   } catch (e) {
     logger.error('Interlinearizer: failed to list projects for source', e);
-    return '[]';
+    throw e;
   }
 }