Disable buttons while submitting/loading, update docs, make implicit zero-check in ContinuousView explicit

Author: alex-rawlings-yyc

src/components/ContinuousView.tsx

@@ -247,7 +247,7 @@ export default function ContinuousView({
   // One ref slot per phrase so we can call scrollIntoView on the focused one.
   const phraseRefs = useRef<(HTMLSpanElement | null)[]>([]);
 
-  const atStart = !phraseEntries.length || !focusPhraseIndex;
+  const atStart = phraseEntries.length === 0 || focusPhraseIndex === 0;
   const atEnd = !phraseEntries.length || focusPhraseIndex >= phraseEntries.length - 1;
   const stripOpacityClass = isVisible ? 'tw:opacity-100' : 'tw:opacity-0';
 

src/components/ProjectMetadataModal.tsx

@@ -244,7 +244,12 @@ export function ProjectMetadataModal({
               {localizedStrings['%interlinearizer_modal_metadata_delete_confirm_body%']}
             </p>
             <div className="tw-flex tw-gap-2 tw-justify-end">
-              <Button variant="secondary" size="sm" onClick={() => setConfirmingDelete(false)}>
+              <Button
+                variant="secondary"
+                size="sm"
+                onClick={() => setConfirmingDelete(false)}
+                disabled={isSubmitting}
+              >
                 {localizedStrings['%interlinearizer_modal_metadata_delete_confirm_cancel%']}
               </Button>
               <Button

src/components/SelectInterlinearProjectModal.tsx

@@ -83,6 +83,7 @@ export function SelectInterlinearProjectModal({
   );
 
   const [projects, setProjects] = useState<InterlinearProjectSummary[]>([]);
+  const [isLoading, setIsLoading] = useState(true);
 
   /**
    * Fetches interlinear projects for `sourceProjectId` and updates the `projects` state. Logs and
@@ -92,6 +93,7 @@ export function SelectInterlinearProjectModal({
    *   sent.
    */
   const loadProjects = useCallback(async () => {
+    setIsLoading(true);
     try {
       const json = await papi.commands.sendCommand(
         'interlinearizer.getProjectsForSource',
@@ -114,6 +116,8 @@ export function SelectInterlinearProjectModal({
       await papi.notifications
         .send({ message: '%interlinearizer_error_load_projects_failed%', severity: 'error' })
         .catch(() => {});
+    } finally {
+      setIsLoading(false);
     }
   }, [sourceProjectId]);
 
@@ -173,10 +177,10 @@ export function SelectInterlinearProjectModal({
         )}
 
         <div className="tw-flex tw-gap-2 tw-justify-end">
-          <Button variant="secondary" onClick={onClose}>
+          <Button variant="secondary" onClick={onClose} disabled={isLoading}>
             {localizedStrings['%interlinearizer_modal_select_cancel%']}
           </Button>
-          <Button onClick={onCreateNew}>
+          <Button onClick={onCreateNew} disabled={isLoading}>
             {localizedStrings['%interlinearizer_modal_select_create_new%']}
           </Button>
         </div>

src/main.ts

@@ -73,7 +73,8 @@ const openWebViewsByProject = new Map<string, string>();
  *
  * @param projectId - Project to open; if omitted a picker dialog is shown.
  * @returns The WebView ID of the opened (or focused) tab, or `undefined` if the user cancels.
- * @throws If `papi.dialogs.selectProject` or `papi.webViews.openWebView` rejects.
+ * @throws If `papi.dialogs.selectProject` rejects (e.g. platform error while showing the dialog).
+ * @throws If `papi.webViews.openWebView` rejects (e.g. the platform cannot open or focus the tab).
  */
 async function openInterlinearizer(projectId?: string): Promise<string | undefined> {
   const resolvedProjectId =
@@ -98,7 +99,8 @@ async function openInterlinearizer(projectId?: string): Promise<string | undefin
  *
  * @param webViewId - ID of an open WebView whose project to use; if omitted falls back to a picker.
  * @returns The WebView ID of the opened (or focused) tab, or `undefined` if the user cancels.
- * @throws If `papi.webViews.getOpenWebViewDefinition` or `openInterlinearizer` rejects.
+ * @throws If `papi.webViews.getOpenWebViewDefinition` rejects.
+ * @throws Any error thrown by {@link openInterlinearizer} (dialog or WebView platform errors).
  */
 async function openInterlinearizerForWebView(webViewId?: string): Promise<string | undefined> {
   if (!webViewId) return openInterlinearizer();
@@ -154,7 +156,11 @@ async function createInterlinearProject(
  *
  * @param interlinearProjectId - UUID of the interlinearizer project to delete.
  * @returns A promise that resolves when the deletion (or no-op) is complete.
- * @throws Re-throws storage errors after logging/notifying so the caller can handle failure UX.
+ * @throws {SyntaxError} If the project-IDs index contains invalid JSON (propagated from
+ *   {@link projectStorage.deleteProject} via {@link readIds}).
+ * @throws If `papi.storage.deleteUserData` rejects for a non-ENOENT reason, or if
+ *   `papi.storage.writeUserData` rejects when updating the index. All storage errors are logged and
+ *   shown as a notification before being re-thrown so the caller can handle failure UX.
  */
 async function deleteInterlinearProject(interlinearProjectId: string): Promise<void> {
   try {
@@ -219,8 +225,10 @@ async function updateProjectMetadata(
  *
  * @param sourceProjectId - Platform.Bible project ID of the source text to query.
  * @returns A JSON string of `InterlinearProject[]`, or `"[]"` if none exist.
- * @throws The storage error when the underlying read fails, so callers can distinguish an outage
- *   from an empty list.
+ * @throws {SyntaxError} If the project-IDs index or any project record contains invalid JSON.
+ * @throws If `papi.storage.readUserData` rejects for a non-ENOENT reason (propagated from
+ *   {@link projectStorage.getProjectsForSource}). Callers can use this to distinguish a storage
+ *   outage from a legitimately empty list.
  */
 async function getProjectsForSource(sourceProjectId: string): Promise<string> {
   try {
@@ -347,7 +355,8 @@ export async function activate(context: ExecutionActivationContext): Promise<voi
     updateProjectMetadata,
     {
       method: {
-        summary: 'Update the name and description of an existing interlinearizer project',
+        summary:
+          'Update the name, description, and analysis language of an existing interlinearizer project',
         params: [
           {
             name: 'interlinearProjectId',

src/parsers/pt9/interlinearXmlParser.ts

@@ -160,10 +160,12 @@ function extractLexemesFromCluster(clusterElement: ParsedCluster): LexemeData[]
  * Parses a string to a non-negative integer, returning `undefined` for empty or non-integer values.
  * Used to validate XML attribute strings before converting them to numeric ranges.
  *
- * @param raw - The string to parse (e.g. an XML attribute value).
- * @returns The parsed non-negative integer, or `undefined` if the input is empty or non-integer.
+ * @param raw - The string to parse (e.g. an XML attribute value). `undefined` is accepted because
+ *   fast-xml-parser may omit attributes at runtime despite the declared type.
+ * @returns The parsed non-negative integer, or `undefined` if the input is absent, empty, or
+ *   non-integer.
  */
-const parseStrictNumber = (raw: string): number | undefined => {
+const parseStrictNumber = (raw: string | undefined): number | undefined => {
   if (raw === undefined || raw.trim() === '') return undefined;
   if (!/^\d+$/.test(raw.trim())) return undefined;
   return Number.parseInt(raw, 10);

src/services/projectStorage.ts

@@ -256,8 +256,12 @@ export async function updateProjectMetadata(
  *
  * @param token - The execution token for storage access.
  * @param id - The project UUID to delete.
- * @throws {SyntaxError} If the `projectIds` storage value contains invalid JSON.
- * @throws If `papi.storage.writeUserData` rejects when updating the index.
+ * @throws {SyntaxError} If the `projectIds` storage value contains invalid JSON (from
+ *   {@link readIds}).
+ * @throws If `papi.storage.deleteUserData` throws for a reason other than ENOENT (non-ENOENT errors
+ *   are rethrown).
+ * @throws If `papi.storage.writeUserData` rejects when updating `PROJECT_IDS_KEY`.
+ * @throws Any error propagated from {@link readIds}, `enqueueProjectOp`, or `enqueueIndexOp`.
  */
 export async function deleteProject(token: ExecutionToken, id: string): Promise<void> {
   await enqueueProjectOp(id, async () => {