Fix duplicate notification and keep create modal open on failure

- Remove papi.notifications.send from createAndPersistProject catch
  block; interlinearizer.createProject already sends its own
  notification before rethrowing, so the second call caused a
  duplicate toast (handleSaveAsNew follows the same convention)
- createAndPersistProject now returns boolean success; callers own
  the modal transition so the create modal stays open on failure,
  preserving the user name/description/language inputs for retry
- useDraftProject.ts newDraft JSDoc updated to reflect that the
  caller is responsible for immediately persisting to the backend

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: imnasnainaec

src/__tests__/components/modals/ProjectModals.test.tsx

@@ -511,7 +511,7 @@ describe('ProjectModals', () => {
       expect(setModal).toHaveBeenCalledWith('none');
     });
 
-    it('falls back to resetActiveProject and closes when backend project creation fails', async () => {
+    it('falls back to resetActiveProject and keeps modal open when backend project creation fails', async () => {
       // Default mock returns undefined; JSON.parse(undefined) throws into the catch block.
       const newDraft = jest.fn();
       const setModal = jest.fn();
@@ -529,7 +529,7 @@ describe('ProjectModals', () => {
 
       await userEvent.click(screen.getByTestId('create-submit'));
 
-      await waitFor(() => expect(setModal).toHaveBeenCalledWith('none'));
+      await waitFor(() => expect(resetActiveProject).toHaveBeenCalledTimes(1));
       expect(newDraft).toHaveBeenCalledWith({
         analysisLanguages: ['en'],
         suggestedName: 'New',
@@ -543,14 +543,10 @@ describe('ProjectModals', () => {
         'New',
         'Desc',
       );
-      expect(papi.notifications.send).toHaveBeenCalledWith({
-        message: '%interlinearizer_error_create_project_failed%',
-        severity: 'error',
-      });
-      expect(resetActiveProject).toHaveBeenCalledTimes(1);
+      expect(setModal).not.toHaveBeenCalledWith('none');
     });
 
-    it('notifies and falls back to resetActiveProject when backend returns a non-project shape', async () => {
+    it('notifies and falls back to resetActiveProject and keeps modal open when backend returns a non-project shape', async () => {
       jest.mocked(papi.commands.sendCommand).mockResolvedValueOnce(JSON.stringify({ bad: true }));
       const setModal = jest.fn();
       const resetActiveProject = jest.fn();
@@ -566,12 +562,12 @@ describe('ProjectModals', () => {
 
       await userEvent.click(screen.getByTestId('create-submit'));
 
-      await waitFor(() => expect(setModal).toHaveBeenCalledWith('none'));
+      await waitFor(() => expect(resetActiveProject).toHaveBeenCalledTimes(1));
       expect(papi.notifications.send).toHaveBeenCalledWith({
         message: '%interlinearizer_error_create_project_failed%',
         severity: 'error',
       });
-      expect(resetActiveProject).toHaveBeenCalledTimes(1);
+      expect(setModal).not.toHaveBeenCalledWith('none');
     });
 
     it('calls setModal with none when the create modal closes without a select source', async () => {

src/components/modals/ProjectModals.tsx

@@ -220,15 +220,17 @@ export default function ProjectModals({
    * project or the draft was empty — nothing is lost. When dirty is `true` the
    * {@link DiscardDraftConfirm} dialog has already obtained explicit user consent to discard.
    *
-   * Sends an error notification on any failure path (matching the convention in {@link openProject})
-   * so the user always gets feedback even when the backend error notification does not reach the
-   * frontend (e.g. a transport-level rejection).
+   * The `interlinearizer.createProject` command sends its own error notification before rethrowing,
+   * so the catch block only needs to log — callers do not need to send a second notification. This
+   * matches {@link handleSaveAsNew}, which uses the same command and follows the same pattern.
    *
    * @param config - The configuration collected by the New dialog.
-   * @returns A promise that resolves once the project is created (or the failure is handled).
+   * @returns `true` if the project was created and persisted successfully; `false` otherwise.
+   *   Callers are responsible for closing the modal on success and keeping it open on failure so
+   *   the user can retry without re-entering their inputs.
    */
   const createAndPersistProject = useCallback(
-    async (config: CreateDraftConfig) => {
+    async (config: CreateDraftConfig): Promise<boolean> => {
       newDraft({
         analysisLanguages: config.analysisLanguages,
         ...(config.name !== undefined && { suggestedName: config.name }),
@@ -254,19 +256,15 @@ export default function ProjectModals({
         }
       } catch (e) {
         logger.error('Interlinearizer: failed to create project from New dialog', e);
-        await papi.notifications
-          .send({ message: '%interlinearizer_error_create_project_failed%', severity: 'error' })
-          .catch(() => {});
       }
       if (created) {
         setActiveProject(created);
       } else {
         resetActiveProject();
       }
-      setCreateSourceIsSelect(false);
-      setModal('none');
+      return created !== undefined;
     },
-    [newDraft, projectId, resetActiveProject, setActiveProject, setModal],
+    [newDraft, projectId, resetActiveProject, setActiveProject],
   );
 
   /**
@@ -286,7 +284,8 @@ export default function ProjectModals({
   /**
    * Called when the New dialog is submitted. Creates and persists the project immediately, or
    * defers behind the unsaved-changes confirmation when the draft is dirty. Disables the modal
-   * buttons via `isCreating` during the backend round-trip.
+   * buttons via `isCreating` during the backend round-trip. Closes on success; stays open on
+   * failure so the user can retry without re-entering their inputs.
    *
    * @param config - The configuration collected by the New dialog.
    */
@@ -298,15 +297,24 @@ export default function ProjectModals({
       }
       setIsCreating(true);
       try {
-        await createAndPersistProject(config);
+        const success = await createAndPersistProject(config);
+        if (success) {
+          setCreateSourceIsSelect(false);
+          setModal('none');
+        }
       } finally {
         setIsCreating(false);
       }
     },
-    [createAndPersistProject, dirty],
+    [createAndPersistProject, dirty, setCreateSourceIsSelect, setModal],
   );
 
-  /** Confirms the deferred draft-replacing action after the user accepts losing unsaved changes. */
+  /**
+   * Confirms the deferred draft-replacing action after the user accepts losing unsaved changes. For
+   * a deferred Open, delegates entirely to {@link openProject}. For a deferred New, closes on
+   * success; on failure the discard confirm is dismissed but the underlying create modal stays
+   * visible so the user can retry.
+   */
   const handleConfirmReplace = useCallback(async () => {
     /* v8 ignore next -- the confirm only renders while a pending action exists */
     if (!pendingReplace) return;
@@ -321,7 +329,11 @@ export default function ProjectModals({
       } else {
         setIsCreating(true);
         try {
-          await createAndPersistProject(pendingReplace.config);
+          const success = await createAndPersistProject(pendingReplace.config);
+          if (success) {
+            setCreateSourceIsSelect(false);
+            setModal('none');
+          }
         } finally {
           setIsCreating(false);
         }
@@ -330,7 +342,14 @@ export default function ProjectModals({
       setIsReplacing(false);
       setPendingReplace(undefined);
     }
-  }, [createAndPersistProject, isReplacing, openProject, pendingReplace]);
+  }, [
+    createAndPersistProject,
+    isReplacing,
+    openProject,
+    pendingReplace,
+    setCreateSourceIsSelect,
+    setModal,
+  ]);
 
   /** Cancels the deferred action, returning to the underlying modal with the draft untouched. */
   const handleCancelReplace = useCallback(() => setPendingReplace(undefined), []);

src/hooks/useDraftProject.ts

@@ -68,9 +68,9 @@ export type UseDraftProjectResult = {
   loadFromProject: (project: OpenableProject) => void;
   /**
    * Starts a fresh, empty draft for the current source — the "New" flow. Seeds the chosen analysis
-   * languages and retains the typed name/description as `suggestedName`/`suggestedDescription` to
-   * prefill Save As; no backend project is created until the user explicitly saves. The new draft
-   * is clean (`dirty: false`), so the unsaved-changes indicator stays clear until the first edit.
+   * languages and retains the typed name/description as `suggestedName`/`suggestedDescription`.
+   * The new draft is clean (`dirty: false`), so the unsaved-changes indicator stays clear until
+   * the first edit. The caller is responsible for immediately persisting the project to the backend.
    *
    * @param config - The languages and optional suggested name/description from the New dialog.
    */