Commit d218031
Fix confirmation overlay not closing properly when errors occur (#120)
* Address code review comments on save-draft-project draft persistence
- Move setPendingReplace(undefined) into finally in handleConfirmReplace so
the DiscardDraftConfirm dialog always dismisses even if a future refactor
makes openProject or startNewDraft throwable
- Add comments documenting the fire-and-forget persistence design and its
failure-visibility trade-offs (dirty flag set optimistically, backend
notification as the sole user signal)
- Add comment on the transient stale dirty indicator when sourceProjectId
changes mid-load (self-corrects; nearly unreachable in practice)
- Add comment explaining why getDraftSnapshot is called at render time in
ProjectModals (ref read is allocation-free; only consumed by saveAs branch)
- Add comment clarifying that per-row Overwrite buttons open the inline
confirmation dialog rather than triggering a save
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Nix less-important comments
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 3d68073 commit d218031
2 files changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| 273 | + | |
273 | 274 | | |
274 | | - | |
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
138 | 145 | | |
139 | 146 | | |
140 | 147 | | |
| |||
0 commit comments