Stop specifying commit IDs

Author: myieye

backend/FwLite/LcmCrdt/CrdtProjectsService.cs

@@ -246,7 +246,7 @@ internal static async Task InitProjectDb(LcmCrdtDbContext db, ProjectData data)
 
     internal static async Task SeedSystemData(DataModel dataModel, ProjectData projectData)
     {
-        await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData, false);
+        await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData);
         await PreDefinedData.AddPredefinedComplexFormTypes(dataModel, projectData);
         await PreDefinedData.AddPredefinedPartsOfSpeech(dataModel, projectData);
         await PreDefinedData.AddPredefinedSemanticDomains(dataModel, projectData);

backend/FwLite/LcmCrdt/CurrentProjectService.cs

@@ -114,7 +114,7 @@ async Task Execute()
                 var projectData = await dbContext.ProjectData.AsNoTracking().FirstAsync();
                 if (!await dbContext.MorphTypes.AnyAsync())
                 {
-                    await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData, true);
+                    await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData);
                 }
 
                 if (EntrySearchServiceFactory is not null)

backend/FwLite/LcmCrdt/Objects/PreDefinedData.cs

@@ -1,6 +1,5 @@
 using LcmCrdt.Changes;
 using SIL.Harmony;
-using UUIDNext;
 
 namespace LcmCrdt.Objects;
 
@@ -16,32 +15,13 @@ public static class PreDefinedData
     public static readonly Guid AdjectivePartOfSpeechId = new("30d07580-5052-4d91-bc24-469b8b2d7df9");
     public static readonly Guid AdverbPartOfSpeechId = new("46e4fe08-ffa0-4c8b-bf98-2c56f38904d9");
 
-    // Seed commit-ids are derived per-project (UUIDv5 namespaced on projectId) so each project
-    // owns its own row in LexBox's CrdtCommits table — a shared constant id would collide on the
-    // primary key and the seed would get attributed to whichever project pushed first.
-    public static Guid ComplexFormTypesSeedCommitId(Guid projectId) =>
-        Uuid.NewNameBased(projectId, "complex-form-types-seed");
-
-    public static Guid SemanticDomainsSeedCommitId(Guid projectId) =>
-        Uuid.NewNameBased(projectId, "semantic-domains-seed");
-
-    public static Guid PartsOfSpeechSeedCommitId(Guid projectId) =>
-        Uuid.NewNameBased(projectId, "parts-of-speech-seed");
-
-    public static Guid CustomViewsSeedCommitId(Guid projectId) =>
-        Uuid.NewNameBased(projectId, "custom-views-seed");
-
-    public static Guid MorphTypesSeedCommitId(Guid projectId) =>
-        Uuid.NewNameBased(projectId, "morph-types-seed");
-
     internal static async Task AddPredefinedComplexFormTypes(DataModel dataModel, ProjectData projectData)
     {
         await dataModel.AddChanges(projectData.ClientId,
             [
                 new CreateComplexFormType(CompoundComplexFormTypeId, new MultiString() { { "en", "Compound" } } ),
                 new CreateComplexFormType(UnspecifiedComplexFormTypeId, new MultiString() { { "en", "Unspecified" } })
-            ],
-            ComplexFormTypesSeedCommitId(projectData.Id));
+            ]);
     }
 
     internal static async Task AddPredefinedSemanticDomains(DataModel dataModel, ProjectData projectData)
@@ -56,8 +36,7 @@ await dataModel.AddChanges(projectData.ClientId,
                 new CreateSemanticDomainChange(new Guid("46e4fe08-ffa0-4c8b-bf88-2c56f38904d4"), new MultiString() { { "en", "Body" } }, "2.1", false),
                 new CreateSemanticDomainChange(new Guid("46e4fe08-ffa0-4c8b-bf88-2c56f38904d5"), new MultiString() { { "en", "Head" } }, "2.1.1", false),
                 new CreateSemanticDomainChange(new Guid("46e4fe08-ffa0-4c8b-bf88-2c56f38904d6"), new MultiString() { { "en", "Eye" } }, "2.1.1.1", false),
-            ],
-            SemanticDomainsSeedCommitId(projectData.Id));
+            ]);
     }
 
     public static async Task AddPredefinedPartsOfSpeech(DataModel dataModel, ProjectData projectData)
@@ -69,8 +48,7 @@ await dataModel.AddChanges(projectData.ClientId,
                 new CreatePartOfSpeechChange(VerbPartOfSpeechId, new MultiString() { { "en", "Verb" } }, true),
                 new CreatePartOfSpeechChange(AdjectivePartOfSpeechId, new MultiString() { { "en", "Adjective" } }, true),
                 new CreatePartOfSpeechChange(AdverbPartOfSpeechId, new MultiString() { { "en", "Adverb" } }, true),
-            ],
-            PartsOfSpeechSeedCommitId(projectData.Id));
+            ]);
     }
 
     internal static async Task AddPredefinedCustomViews(DataModel dataModel, ProjectData projectData)
@@ -100,14 +78,12 @@ await dataModel.AddChanges(projectData.ClientId,
                         Vernacular = [new ViewWritingSystem { WsId = "de" }, new ViewWritingSystem { WsId = "de-Zxxx-x-audio" }],
                         Analysis = [new ViewWritingSystem { WsId = "en" }]
                     })
-            ],
-            CustomViewsSeedCommitId(projectData.Id));
+            ]);
     }
 
-    internal static async Task AddPredefinedMorphTypes(DataModel dataModel, ProjectData projectData, bool isMigration)
+    internal static async Task AddPredefinedMorphTypes(DataModel dataModel, ProjectData projectData)
     {
         await dataModel.AddChanges(projectData.ClientId,
-            [.. CanonicalMorphTypes.All.Values.Select(mt => new CreateMorphTypeChange(mt))],
-            isMigration ? Guid.NewGuid() : MorphTypesSeedCommitId(projectData.Id));
+            [.. CanonicalMorphTypes.All.Values.Select(mt => new CreateMorphTypeChange(mt))]);
     }
 }