Refine IsMain publication tests and validation after review

Consolidate the get-or-create main-publication helper onto MiniLcmTestBase
(shared by the publication and create-entry conformance tests, reusing the
project's existing main rather than minting a second). Make the REST route's
CreateEntryOptions defaults explicit via ToOptions(defaults), extract
CreatePublicationChange.MainAlreadyExists, and make DoesNotChangePropertyTo
generic over the forbidden value's type.

Drop the dry-run PublicationSyncTests: the collection-level promotion it
guarded was removed when IsMain moved into standard per-publication diffing,
so the failure mode it covered is structurally gone.

Fix entry-api-helper to inline the create-entry options inside page.evaluate
— module imports are closure variables that don't cross the Playwright
serialization boundary, so referencing the shared helper there throws.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: myieye

backend/FwLite/FwDataMiniLcmBridge.Tests/MiniLcmTests/PublicationsTests.cs

@@ -1,7 +1,4 @@
-using FwDataMiniLcmBridge.Api;
 using FwDataMiniLcmBridge.Tests.Fixtures;
-using MiniLcm.Models;
-using SIL.LCModel.Infrastructure;
 
 namespace FwDataMiniLcmBridge.Tests.MiniLcmTests;
 
@@ -12,17 +9,4 @@ protected override Task<IMiniLcmApi> NewApi()
     {
         return Task.FromResult<IMiniLcmApi>(fixture.NewProjectApi("publications-test", "en", "en"));
     }
-
-    // FieldWorks' main publication is its protected one; the MiniLcm write path deliberately never flips
-    // IsProtected (see UpdatePublicationProxy), so seed it directly at the LCM layer for these tests.
-    protected override async Task<Publication> SeedMainPublication(string name = "Main")
-    {
-        var fwApi = (FwDataMiniLcmApi)BaseApi;
-        var pub = await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", name } } });
-        var lcmPublication = fwApi.GetLcmPublication(pub.Id)
-            ?? throw new InvalidOperationException($"Seeded publication {pub.Id} not found in LCM");
-        NonUndoableUnitOfWorkHelper.DoUsingNewOrCurrentUOW(fwApi.Cache.ServiceLocator.ActionHandler,
-            () => lcmPublication.IsProtected = true);
-        return await Api.GetPublication(pub.Id) ?? throw new InvalidOperationException($"Seeded main {pub.Id} not found");
-    }
 }

backend/FwLite/FwLiteProjectSync.Tests/EntrySyncTests.cs

@@ -312,19 +312,19 @@ public async Task CanSyncRandomEntries(ApiType? roundTripApiType)
         var expected = after.Copy();
 
         // Don't auto-add the main publication when staging data: the sync path under test (EntrySync) never does.
-        var noAutoMain = new CreateEntryOptions(AutoAddMainPublication: false);
+        var asIsEntryOptions = CreateEntryOptions.AsIs;
         if (roundTripApi is not null)
         {
             // round-tripping ensures we're dealing with realistic data
             // (e.g. in fwdata ComplexFormComponents do not have an Id)
-            before = await roundTripApi.CreateEntry(before, noAutoMain);
+            before = await roundTripApi.CreateEntry(before, asIsEntryOptions);
             await roundTripApi.DeleteEntry(before.Id);
-            after = await roundTripApi.CreateEntry(after, noAutoMain);
+            after = await roundTripApi.CreateEntry(after, asIsEntryOptions);
             await roundTripApi.DeleteEntry(after.Id);
         }
 
         // before should not be round-tripped here. That's handled above.
-        await Api.CreateEntry(before, noAutoMain);
+        await Api.CreateEntry(before, asIsEntryOptions);
 
         // act
         await EntrySync.SyncFull(before, after, Api);

backend/FwLite/FwLiteProjectSync.Tests/PublicationSyncTests.cs

@@ -4,7 +4,6 @@
 using LexCore.Sync;
 using Microsoft.Extensions.Logging;
 using MiniLcm;
-using MiniLcm.Models;
 using MiniLcm.SyncHelpers;
 using MiniLcm.Validators;
 

backend/FwLite/FwLiteProjectSync/CrdtFwdataProjectSyncService.cs

@@ -174,11 +174,11 @@ public static IAsyncEnumerable<Publication> GetPublications([FromServices] MiniL
         }
 
         public static Task<Entry> PostEntry([FromBody] Entry entry,
-            [AsParameters] CreateEntryParams options,
+            [AsParameters] CreateEntryOptionsParams paramOptions,
             [FromServices] MiniLcmHolder holder)
         {
             var api = holder.MiniLcmApi;
-            return api.CreateEntry(entry, options.ToOptions());
+            return api.CreateEntry(entry, paramOptions.ToOptions(defaults: CreateEntryOptions.WithMainPublication));
         }
 
         public static Task DeleteEntry(Guid id, [FromServices] MiniLcmHolder holder)
@@ -188,19 +188,16 @@ public static Task DeleteEntry(Guid id, [FromServices] MiniLcmHolder holder)
         }
     }
 
-    private class CreateEntryParams
+    private class CreateEntryOptionsParams
     {
         [FromQuery]
         public bool? AutoAddMainPublication { get; set; }
-
         [FromQuery]
         public bool? IncludeComplexFormsAndComponents { get; set; }
 
-        // Unspecified defaults to interactive-creation behaviour (auto-add the main publication), not the
-        // CreateEntryOptions record default, which is the opposite.
-        public CreateEntryOptions ToOptions() => new(
-            IncludeComplexFormsAndComponents: IncludeComplexFormsAndComponents ?? true,
-            AutoAddMainPublication: AutoAddMainPublication ?? true);
+        public CreateEntryOptions ToOptions(CreateEntryOptions defaults) => new(
+            IncludeComplexFormsAndComponents: IncludeComplexFormsAndComponents ?? defaults.IncludeComplexFormsAndComponents,
+            AutoAddMainPublication: AutoAddMainPublication ?? defaults.AutoAddMainPublication);
     }
 
     private class MiniLcmQueryOptions