AI feedback

Author: myieye

frontend/viewer/src/lib/components/field-editors/select.svelte

@@ -126,14 +126,15 @@
       <CommandEmpty>{emptyResultsPlaceholder ?? $t`No items found`}</CommandEmpty>
       <CommandGroup>
         {#if nullOption}
+          {@const selected = value === undefined || value === null}
           <CommandItem
             keywords={[nullOption]}
             onSelect={() => selectValue(undefined)}
             class="group max-md:h-12 text-muted-foreground"
             data-value-index={-1}
             aria-label={nullOption}
           >
-            <Icon icon="i-mdi-check" class={cn('md:hidden', value === null || 'invisible')} />
+            <Icon icon="i-mdi-check" class={cn('md:hidden', selected || 'invisible')} />
             {nullOption}
           </CommandItem>
         {/if}

frontend/viewer/src/lib/components/ui/switch/switch.svelte

@@ -20,7 +20,7 @@
     bind:checked
     class={cn(
       'focus-visible:ring-ring focus-visible:ring-offset-background data-[state=checked]:bg-primary data-[state=unchecked]:bg-input peer inline-flex h-6 w-11 shrink-0 cursor-pointer items-center rounded-full border-2 border-transparent transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50',
-      label || className,
+      !!label || className,
     )}
     {...restProps}
   >

frontend/viewer/src/project/browse/filter/FieldSelect.svelte

@@ -1,4 +1,6 @@
 <script lang="ts" module>
+  import type {WritingSystemSelection} from '$lib/writing-system-service.svelte';
+
   export type SelectedField = {
     id: string;
     ws: WritingSystemSelection;
@@ -10,7 +12,6 @@
   import {t} from 'svelte-i18n-lingui';
   import {pt} from '$lib/views/view-text';
   import {useCurrentView} from '$lib/views/view-service';
-  import type {WritingSystemSelection} from '$lib/writing-system-service.svelte';
 
   let {value = $bindable()}: { value: SelectedField | null } = $props();
 

frontend/viewer/src/project/browse/filter/SemanticDomainSelect.svelte

@@ -1,12 +1,14 @@
 <script lang="ts" module>
+  import type {WritingSystemSelection} from '$lib/writing-system-service.svelte';
+
   export type SelectedField = {
     id: string;
     ws: WritingSystemSelection;
   }
 </script>
 
 <script lang="ts">
-  import {useWritingSystemService, type WritingSystemSelection} from '$lib/writing-system-service.svelte';
+  import {useWritingSystemService} from '$lib/writing-system-service.svelte';
   import {useSemanticDomains} from '$lib/semantic-domains';
   import type {ISemanticDomain} from '$lib/dotnet-types';
   import {Select} from '$lib/components/field-editors';