Run the main-publication invariant tests on FwData too

The single-main guards are enforced in the backend-agnostic validation wrapper, so move them to PublicationsTestsBase. FwData maps IsMain from the read-only IsProtected, so the FwData test seeds a main at the LCM layer. The promotion and merge-convergence tests stay CRDT-only.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: myieye

backend/FwLite/FwDataMiniLcmBridge.Tests/MiniLcmTests/PublicationsTests.cs

@@ -1,4 +1,7 @@
+using FwDataMiniLcmBridge.Api;
 using FwDataMiniLcmBridge.Tests.Fixtures;
+using MiniLcm.Models;
+using SIL.LCModel.Infrastructure;
 
 namespace FwDataMiniLcmBridge.Tests.MiniLcmTests;
 
@@ -9,4 +12,17 @@ protected override Task<IMiniLcmApi> NewApi()
     {
         return Task.FromResult<IMiniLcmApi>(fixture.NewProjectApi("publications-test", "en", "en"));
     }
+
+    // FieldWorks' main publication is its protected one; the MiniLcm write path deliberately never flips
+    // IsProtected (see UpdatePublicationProxy), so seed it directly at the LCM layer for these tests.
+    protected override async Task<Publication> SeedMainPublication(string name = "Main")
+    {
+        var fwApi = (FwDataMiniLcmApi)BaseApi;
+        var pub = await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", name } } });
+        var lcmPublication = fwApi.GetLcmPublication(pub.Id)
+            ?? throw new InvalidOperationException($"Seeded publication {pub.Id} not found in LCM");
+        NonUndoableUnitOfWorkHelper.DoUsingNewOrCurrentUOW(fwApi.Cache.ServiceLocator.ActionHandler,
+            () => lcmPublication.IsProtected = true);
+        return await Api.GetPublication(pub.Id) ?? throw new InvalidOperationException($"Seeded main {pub.Id} not found");
+    }
 }

backend/FwLite/LcmCrdt.Tests/MiniLcmTests/PublicationsTests.cs

@@ -20,37 +20,6 @@ public override async Task DisposeAsync()
         await _fixture.DisposeAsync();
     }
 
-    [Fact]
-    public async Task UpdatePublication_CannotTurnOffIsMain()
-    {
-        var main = await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", "Main" } }, IsMain = true });
-
-        var act = () => Api.UpdatePublication(main.Id, new UpdateObjectInput<Publication>().Set(p => p.IsMain, false));
-
-        await act.Should().ThrowAsync<FluentValidation.ValidationException>();
-    }
-
-    [Fact]
-    public async Task UpdatePublication_CannotPromoteSecondMain()
-    {
-        await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", "Main" } }, IsMain = true });
-        var other = await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", "Pocket" } } });
-
-        var act = () => Api.UpdatePublication(other.Id, new UpdateObjectInput<Publication>().Set(p => p.IsMain, true));
-
-        await act.Should().ThrowAsync<InvalidOperationException>();
-    }
-
-    [Fact]
-    public async Task CreatePublication_CannotCreateSecondMain()
-    {
-        await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", "Main" } }, IsMain = true });
-
-        var act = () => Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", "Second" } }, IsMain = true });
-
-        await act.Should().ThrowAsync<InvalidOperationException>();
-    }
-
     [Fact]
     public async Task PublicationSync_PromotesExistingPublicationToMain()
     {

backend/FwLite/MiniLcm.Tests/PublicationsTestsBase.cs

@@ -110,4 +110,41 @@ public async Task UpdatePublication_WithBeforeAndAfter_Works()
         var actualPub = await Api.UpdatePublication(publication, afterPub);
         actualPub.Should().BeEquivalentTo(afterPub);
     }
+
+    /// <summary>Creates the project's single main publication. Overridden per backend (e.g. FwData maps it to a protected publication).</summary>
+    protected virtual async Task<Publication> SeedMainPublication(string name = "Main")
+    {
+        return await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", name } }, IsMain = true });
+    }
+
+    [Fact]
+    public async Task CreatePublication_CannotCreateSecondMain()
+    {
+        await SeedMainPublication();
+
+        var act = () => Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", "Second" } }, IsMain = true });
+
+        await act.Should().ThrowAsync<InvalidOperationException>();
+    }
+
+    [Fact]
+    public async Task UpdatePublication_CannotPromoteSecondMain()
+    {
+        await SeedMainPublication();
+        var other = await Api.CreatePublication(new Publication { Id = Guid.NewGuid(), Name = { { "en", "Pocket" } } });
+
+        var act = () => Api.UpdatePublication(other.Id, new UpdateObjectInput<Publication>().Set(p => p.IsMain, true));
+
+        await act.Should().ThrowAsync<InvalidOperationException>();
+    }
+
+    [Fact]
+    public async Task UpdatePublication_CannotTurnOffIsMain()
+    {
+        var main = await SeedMainPublication();
+
+        var act = () => Api.UpdatePublication(main.Id, new UpdateObjectInput<Publication>().Set(p => p.IsMain, false));
+
+        await act.Should().ThrowAsync<FluentValidation.ValidationException>();
+    }
 }