Deleting test projects now deletes FwHeadless repo (#1937)

* Deleting test projects now deletes FwHeadless repo
* Invalidate caches after deleting project

Author: rmunn

backend/LexBoxApi/Controllers/ProjectController.cs

@@ -170,15 +170,12 @@ public async Task<ActionResult> FinishResetProject(string code)
     [AdminRequired]
     public async Task<ActionResult<Project>> DeleteProject(Guid id)
     {
-        //this project is only for testing purposes. It will delete projects permanently from the database.
+        //this endpoint is only for testing purposes. It will delete projects permanently from the database.
         var project = await lexBoxDbContext.Projects.FindAsync(id);
         if (project is null) return NotFound();
         if (project.RetentionPolicy != RetentionPolicy.Dev) return Forbid();
-        lexBoxDbContext.Projects.Remove(project);
-        var hgService = HttpContext.RequestServices.GetRequiredService<IHgService>();
-        await hgService.DeleteRepo(project.Code);
-        project.UpdateUpdatedDate();
-        await lexBoxDbContext.SaveChangesAsync();
+        project = await projectService.DeleteProjectPermanently(id);
+        if (project is null) return NotFound();
         return project;
     }
 

backend/LexBoxApi/Services/ProjectService.cs

@@ -200,6 +200,25 @@ public async Task FinishReset(string code, Stream? zipFile = null)
         await dbContext.SaveChangesAsync();
     }
 
+    public async Task<Project?> DeleteProjectPermanently(Guid projectId)
+    {
+        // This method should only be called for test projects, like those created during E2E tests
+        var project = await dbContext.Projects.FindAsync(projectId);
+        // These checks *should* be redundant with the ProjectController's checks, but do them again anyway
+        if (project is null) return null;
+        if (project.RetentionPolicy != RetentionPolicy.Dev) return null;
+        dbContext.Projects.Remove(project);
+        await hgService.DeleteRepo(project.Code);
+        await fwHeadless.DeleteRepo(projectId);
+        project.UpdateUpdatedDate();
+        // Don't forget to add more Invalidate calls here if we add new caches
+        InvalidateProjectCodeCache(project.Code);
+        InvalidateProjectConfidentialityCache(projectId);
+        InvalidateProjectOrgIdsCache(projectId);
+        await dbContext.SaveChangesAsync();
+        return project;
+    }
+
     public async ValueTask<Guid[]> LookupProjectOrgIds(Guid projectId)
     {
         var cacheKey = $"ProjectOrgsForId:{projectId}";