only seed morphtypes when needed, only use a predefined commit id when seeding. Modify CreateMorphTypeChange to handle creating the same morph type multiple times due to migrations.

Author: hahn-kev

backend/FwLite/LcmCrdt/Changes/CreateMorphTypeChange.cs

@@ -8,7 +8,7 @@
 
 namespace LcmCrdt.Changes;
 
-public class CreateMorphTypeChange : CreateChange<MorphType>, ISelfNamedType<CreateMorphTypeChange>
+public class CreateMorphTypeChange : Change<MorphType>, ISelfNamedType<CreateMorphTypeChange>
 {
     [SetsRequiredMembers]
     public CreateMorphTypeChange(MorphType morphType) : base(morphType.Id)
@@ -58,4 +58,10 @@ public override async ValueTask<MorphType> NewEntity(Commit commit, IChangeConte
             DeletedAt = alreadyExists ? commit.DateTime : null
         };
     }
+
+    public override ValueTask ApplyChange(MorphType entity, IChangeContext context)
+    {
+        //don't do anything here, CreateMorphTypeChange is used in a migration, and a change to create the same morph type may happen multiple times
+        return ValueTask.CompletedTask;
+    }
 }

backend/FwLite/LcmCrdt/CrdtProjectsService.cs

@@ -242,7 +242,7 @@ internal static async Task InitProjectDb(LcmCrdtDbContext db, ProjectData data)
 
     internal static async Task SeedSystemData(DataModel dataModel, ProjectData projectData)
     {
-        await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData);
+        await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData, false);
         await PreDefinedData.AddPredefinedComplexFormTypes(dataModel, projectData);
         await PreDefinedData.AddPredefinedPartsOfSpeech(dataModel, projectData);
         await PreDefinedData.AddPredefinedSemanticDomains(dataModel, projectData);

backend/FwLite/LcmCrdt/CurrentProjectService.cs

@@ -112,7 +112,10 @@ async Task Execute()
                 // Must happen BEFORE FTS regeneration so headwords include morph-type tokens.
                 var dataModel = services.GetRequiredService<DataModel>();
                 var projectData = await dbContext.ProjectData.AsNoTracking().FirstAsync();
-                await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData);
+                if (!await dbContext.MorphTypes.AnyAsync())
+                {
+                    await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData, true);
+                }
 
                 if (EntrySearchServiceFactory is not null)
                 {

backend/FwLite/LcmCrdt/Objects/PreDefinedData.cs

@@ -104,10 +104,10 @@ await dataModel.AddChanges(projectData.ClientId,
             CustomViewsSeedCommitId(projectData.Id));
     }
 
-    internal static async Task AddPredefinedMorphTypes(DataModel dataModel, ProjectData projectData)
+    internal static async Task AddPredefinedMorphTypes(DataModel dataModel, ProjectData projectData, bool isMigration)
     {
         await dataModel.AddChanges(projectData.ClientId,
             [.. CanonicalMorphTypes.All.Values.Select(mt => new CreateMorphTypeChange(mt))],
-            MorphTypesSeedCommitId(projectData.Id));
+            isMigration ? Guid.NewGuid() : MorphTypesSeedCommitId(projectData.Id));
     }
 }