Turn off @typescript-eslint/no-redundant-type-constituents

Author: imnasnainaec

frontend/eslint.config.js

@@ -38,11 +38,12 @@ export default [
     files: ['**/*.svelte'],
     rules: {
       // The Svelte plugin doesn't seem to have typing quite figured out
+      '@typescript-eslint/no-redundant-type-constituents': 'off',
+      '@typescript-eslint/no-unsafe-argument': 'off',
       '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
       '@typescript-eslint/no-unsafe-call': 'off',
+      '@typescript-eslint/no-unsafe-member-access': 'off',
       '@typescript-eslint/no-unsafe-return': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
     },
   },
   ...svelte.configs.recommended,

frontend/src/lib/components/FilterBar/FilterBar.svelte

@@ -22,7 +22,6 @@
   import { DEFAULT_DEBOUNCE_TIME } from '$lib/util/time';
 
   type DumbFilters = $$Generic<Record<string, unknown>>;
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   type Filters = DumbFilters & Record<typeof searchKey, string>;
 
   let searchInput: PlainInput | undefined = $state();

frontend/src/lib/components/Projects/ProjectConfidentialityFilterSelect.svelte

@@ -6,7 +6,6 @@
   import type { Confidentiality } from './ProjectFilter.svelte';
 
   interface Props extends Omit<SelectProps, 'label'> {
-    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents -- false positive
     value: Confidentiality | undefined;
   }
 

frontend/src/lib/components/modals/ConfirmDeleteModal.svelte

@@ -41,7 +41,6 @@
 
   type Schema = typeof verify;
 
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   let deletionFormModal: FormModal<Schema> | undefined = $state();
   let deletionForm = $derived(deletionFormModal?.form());
 </script>

frontend/src/lib/components/modals/FormModal.svelte

@@ -58,12 +58,12 @@
   let done = $state(false);
 
   export async function open(
-    value: Partial<FormType> | undefined, //eslint-disable-line @typescript-eslint/no-redundant-type-constituents
+    value: Partial<FormType> | undefined,
     onSubmit: SubmitCallback,
   ): Promise<FormModalResult<Schema>>;
   export async function open(onSubmit: SubmitCallback): Promise<FormModalResult<Schema>>;
   export async function open(
-    valueOrOnSubmit: Partial<FormType> | SubmitCallback | undefined, //eslint-disable-line @typescript-eslint/no-redundant-type-constituents
+    valueOrOnSubmit: Partial<FormType> | SubmitCallback | undefined,
     _onSubmit?: SubmitCallback,
   ): Promise<FormModalResult<Schema>> {
     done = false;

frontend/src/routes/(authenticated)/admin/+page.svelte

@@ -41,7 +41,6 @@
     showDeletedProjects: queryParam.boolean<boolean>(false),
     hideDraftProjects: queryParam.boolean<boolean>(false),
     emptyProjects: queryParam.boolean<boolean>(false),
-    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents -- false positive?
     confidential: queryParam.string<Confidentiality | undefined>(undefined),
     projectType: queryParam.string<ProjectType | undefined>(undefined),
     memberSearch: queryParam.string(undefined),

frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte

@@ -39,7 +39,6 @@
 
   type Schema = typeof schema;
   type RefinedSchema = typeof refinedSchema;
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   let formModal: FormModal<RefinedSchema> | undefined = $state();
 
   export function close(): void {

frontend/src/routes/(authenticated)/org/[org_id]/AddMyProjectsToOrgModal.svelte

@@ -21,7 +21,6 @@
 
   const schema = z.object({});
 
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   let formModal: FormModal<typeof schema> | undefined = $state();
   let newProjects: Project[] = $state([]);
   let alreadyAddedProjects: number = $state(0);

frontend/src/routes/(authenticated)/org/[org_id]/AddOrgMemberModal.svelte

@@ -28,7 +28,6 @@
     role: z.enum([OrgRole.User, OrgRole.Admin]).default(OrgRole.User),
     canInvite: z.boolean().default(false),
   });
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   let formModal: FormModal<typeof schema> | undefined = $state();
   let form = $derived(formModal?.form());
 

frontend/src/routes/(authenticated)/org/[org_id]/BulkAddOrgMembers.svelte

@@ -31,7 +31,6 @@
     usernamesText: z.string().trim().min(1, $t('org_page.bulk_add_members.empty_user_field')),
   });
 
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
   let formModal: FormModal<typeof schema> | undefined = $state();
   let form = $derived(formModal?.form());