Revert running "deprecated" data migrations in all regression tests

Author: myieye

backend/FwLite/LcmCrdt.Tests/Data/DownloadProjectTests.cs

@@ -1,6 +1,5 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
 using SIL.Harmony.Core;
 
 namespace LcmCrdt.Tests.Data;
@@ -13,7 +12,7 @@ public class DownloadProjectTests : IAsyncLifetime
 
     public async Task InitializeAsync()
     {
-        await _helper.InitializeAsync(RegressionTestHelper.RegressionVersion.v2);
+        await _helper.InitializeAsync(RegressionTestHelper.RegressionVersion.v2, withDataMigrations: true);
         //add a change after migration which creates MorphTypes
         await _helper.Services.GetRequiredService<IMiniLcmApi>().CreateEntry(new Entry()
         {

backend/FwLite/LcmCrdt.Tests/Data/RegressionTestHelper.cs

@@ -33,23 +33,34 @@ private async Task InitDbFromScripts(RegressionVersion version)
         //need to close the connection, otherwise the collations won't get created, they would normally be created on open or save, so we're closing so they get created when EF opens the connection.
         await dbConnection.CloseAsync();
 
-        //setup again to trigger migrations
-        await projectsService.SetupProjectContext(_crdtProject);
+        await lcmCrdtDbContext.Database.MigrateAsync();
+
+        await projectsService.RefreshProjectData();
     }
 
     public Task InitializeAsync()
     {
         return InitializeAsync(RegressionVersion.v2);
     }
 
-    public async Task InitializeAsync(RegressionVersion version)
+    public async Task InitializeAsync(RegressionVersion version, bool withDataMigrations = false)
     {
         var builder = Host.CreateEmptyApplicationBuilder(null);
         builder.Services.AddTestLcmCrdtClient();
         _host = builder.Build();
         var services = _host.Services;
         _asyncScope = services.CreateAsyncScope();
         await InitDbFromScripts(version);
+
+        // Data migrations are already on their way out. It doesn't really make sense for all tests to run them,
+        // which would change a bunch of verified project snapshots.
+        // When data migrations are removed, we should run this code unconditionally
+        // at the end of InitDbFromScripts (instead of the current db-migration and refresh-project-data approach)
+        // Because that's closer to the prod code.
+        if (withDataMigrations)
+        {
+            await Services.GetRequiredService<CurrentProjectService>().SetupProjectContext(_crdtProject);
+        }
     }
 
     public async Task DisposeAsync()