ShadCN UI main#1589
Merged
Merged
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 78 files out of 185 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit 5a48a98. ♻️ This comment has been updated with latest results. |
Contributor
* setup screenshot testing using playwright * ensure UI is consistent for tests by removing date from dev version and by not changing the sync icon --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
# Conflicts: # frontend/viewer/src/project/ProjectDropdown.svelte
* use shadCn dialog for NewEntryDialog * Refactor DeleteDialog to use the ShadCN dialog * use ShadCN dialog in ActivityView.svelte and HistoryView.svelte * convert About and Troubleshooting Dialog to use shadCN --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
* change writing system service to use runes and the new project context. * use project context for history service * fix proxy issues due to some rune and resource stuff * setup parts of speech service * migrate complex form types to use runes
* Refactor editor classes to editor components * Extract editor sandbox into own component * Fix invalid binding * Introduce editor root and name editor container --------- Co-authored-by: Kevin Hahn <kevin_hahn@sil.org>
* use a boundry on failing areas in the sandbox. Tweak index.html to only send to testing when the path is empty * convert EntryOrSensePicker.svelte to svelte 5 and ShadCN * use a ring to indicate selection of entry rows * move new entry dialog and delete dialog to use a new dialog service based on project context * migrate save handler * pull Add entry button out of sidebar and create SidebarPrimaryAction.svelte which will place a button in the sidebar with context of the current view. * Fix stacking dialogs * Fix selecting newly created entry --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
* Fix sandbox * Make Editor.Field.Body only 1 column by default * Add note to sandbox editor * Remove min-height from multi-select on desktop * Add single-select component to sandbox editor * Remove badge from empty single-select * Incorporate PR feedback
* Make rich-text-editor support readonly mode * add a checkbox to toggle readonly mode on sandbox. Wrap the rich editor with label in a div otherwise the cursor is incorrect when hovering over the editor. --------- Co-authored-by: Kevin Hahn <kevin_hahn@sil.org>
* Fix entry-view scroll-area overflowing parent * Prevent new-entry-button from being covered up by sidebar menu items * Fix filter-field outline overflowing and tweak padding/margins * Make refresh button more distinct and animation less jittery * Use icon button size for entry-view icon buttons * Add gap between entry-view icon buttons
* Add radio button comment for our future selves * Add multi-ws-input and simple inputs to sandbox editor * Fix up readonly field-editor props * Put value preview beside sandbox editor
* add new EntryDeletedEvent and notify on delete from sync or the notify wrapper * introduce a project event bus use the bus for entry deleted events * document how to use shadcn * add a right click menu to the entries list to enable deleting entries * add open in new to entry menu * use entry menu for entry list context menu closes #1640 --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
* display a dictionary preview on the entry list * make sense numbers links in dictionary preview * show dictionary preview in the entry view * allow making the preview sticky --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
* Introduce EntryEditorPrimitive * Rename SenseEditor to SenseEditorPrimitive. That's what it is. * Rename ExampleEditor to ExampleEditorPrimitive * Replace grid-layer class with EditorSubGrid component * Add onchange events to fields * Truncate selects to first 100 filtered items with hint at end of truncated list * Introduce view-text helper/type for lite vs classic texts * Add readonly dev toggle. * Wrap editor in Editor.Root * Migrate sense fields to shadcn * Migrate entry fields to shadcn * Migrate example sentence fields to shadcn * Some clean up * Extend pickViewText api and translate editor headers * Silence warnings by binding entry objects * Fix field borders peeking around side of sticky header at some zoom-levels.
* Fix can't open fwdata projects if crdt project with same code exists * Reuse Lexbox project name for fwdata projects * Fix crdt copy not shown in project-picker if fwdata copy exists. And sort. * Fix crdt and fwdata copies always highlighted together on hover * Fix current fwdata project not highlighted in project-picker if crdt copy also exists * Fix both crdt and fwdata copies of current project highlighted in project-picker * Fix: project code not shown on synced server projects
…ons (#1655) * Make icon and icon buttons support baseline alignment * Migrate component and complex-forms to shadcn/Svelte 5 * Prevent focus rings from being clipped and tweak preview position on mobile * Migrate rest of editor to Svelte 5 and shadcn * Remove reorderer-swapper and use svelte-context in reorderr hierarchy * Make new sense FAB look like new entry FAB * Rehide reorderer if only 1 item * Move pickIcon into the only component that now uses it * write a sandbox test for the reorderer * translate delete prompt text * Use getters instead of $state so root-props react to updates. * Use simple $derived.by instead of watch --------- Co-authored-by: Kevin Hahn <kevin_hahn@sil.org>
* create QueryParamState to enable reactive url params * fix bug in EntryOrSenseItemList.svelte to remove a trailing `}` from the query parameter * make the browse view `selectedEntryId` reactive based on query params * make dialogs reactive to url and the back button * use router for handling browse and tasks views * add a fallback default route in the project view --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
# Conflicts: # frontend/src/routes/(authenticated)/project/[project_code]/viewer/+page.svelte # frontend/viewer/src/SvelteUxProjectView.svelte # frontend/viewer/src/lib/entry-editor/field-editors/MultiOptionEditor.test.svelte.ts # frontend/viewer/src/lib/sandbox/OptionSandbox.svelte
* add a border to an empty server list * migrate LocalizationPicker.svelte to use Shad CN and not the Svelte UX menu * slide icons and loading indicator on change * remove svelte-ux on sandbox page --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
* Fix delete dialog close detection * Wire up sidebar and hide unimplemented content * Migrate home-page app-bar buttons to shadcn * Use function instead of prop to open troubleshooting dialog * Fix broken enter animation due to troubleshooting dialog resize after open. * Introduce responsive-menu for entry-menu * Add Open in FieldWorks button * Fix logo doesn't respond to dark-mode * Condense home-view app-bar * Make radio buttons bigger on mobile * only show Open In Flex button when supported --------- Co-authored-by: Kevin Hahn <kevin_hahn@sil.org>
* notify entry changes when sense or example are deleted * make entry persistence service to attach to entry editor * Use project-code for detecting project events * Fix entry ID mismatch after changing entries --------- Co-authored-by: Tim Haasdyk <tim_haasdyk@sil.org>
* add QueryParamState option for using replace when a default value is set * replace dialogs using QueryParamState with `useBackHandler` * use back handler in drawer on mobile. Cleanup back handler when it's component is destroyed * handle case where we navigate from an open dialog and warn that history was not cleaned up
myieye
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1587
other ShadCN related PR's should have a base of
shadcn-ui-main.This PR should not be merged in until we're ready to release ShadCN.
Currently done update as needed: