fix playwright test failures on admin dashboard by hahn-kev · Pull Request #1665 · sillsdev/languageforge-lexbox

hahn-kev · 2025-05-14T09:54:10Z

there were cycles between value and debouncer.current which triggered issues in tests

coderabbitai · 2025-05-14T09:54:18Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes update the debouncing logic in the DebouncedInput component by replacing $effect with watch from the runed library. Additionally, the sandbox page is extended to showcase the DebouncedInput component, introducing new reactive state variables and UI elements for demonstrating debounced input behavior.

Changes

Files/Groups	Change Summary
frontend/src/lib/forms/DebouncedInput.svelte	Replaced `$effect` with `watch` from `runed` for reactive effects; updated import statements accordingly.
frontend/src/routes/(unauthenticated)/sandbox/+page.svelte	Added DebouncedInput demo: imported component, introduced `inputValue` and `inputUndebouncedValue`, and updated UI.

Poem

A rabbit hops with nimble feet,
DebouncedInput now skips a beat!
With "watch" it spies each value shift,
And in the sandbox, gives a gift—
A field that waits, then shows its mind,
In code and UI, both aligned!
🐇⌨️✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-14T09:54:57Z

UI unit Tests

12 tests ±0 12 ✅ ±0 0s ⏱️ ±0s
4 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 82de993. ± Comparison against base commit bc88edf.

♻️ This comment has been updated with latest results.

github-actions · 2025-05-14T09:56:37Z

C# Unit Tests

116 tests ±0 116 ✅ ±0 9s ⏱️ -1s
17 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 82de993. ± Comparison against base commit bc88edf.

♻️ This comment has been updated with latest results.

Don't use DebouncedInput in FilterBar as it's causing Playwright test failures where links briefly aren't clickable. Doing the debouncing directly in FilterBar eliminates the issue.

rmunn · 2025-05-15T04:32:36Z

Might be superseded by #1666: this PR still had some test failures, but if we just get rid of the DebouncedInput component entirely and just use PlainInput, where we're not binding to both the undebounced and debounced value at the same time, that eliminates all test failures. So instead of modifying DebouncedInput, #1666 just gets rid of it.

EDIT: It all goes away in the squash anyway. Closing #1666 in favor of this one instead.

No longer used anywhere

rmunn · 2025-05-15T05:43:38Z

@hahn-kev - Although you started this PR, the code that will actually be merged is all mine. So really, you should review it, but GitHub won't let me request your review. Want to give it an unofficial (from GitHub's perspective) review which I will then rubber-stamp?

myieye · 2025-05-15T09:30:21Z

I'm trying a few things out myself before I surrender to the fact that we're incapable of making a stable DebouncedInput component 😭...

myieye

Well, I tried a few things and none of them worked.
So, it's probably a good idea to go with this for the time being.

Good job making it not break anymore Robin.

use watch instead of $effect to avoid change cycles

4b4cf27

Have FilterBar do its own debouncing

d547aeb

Don't use DebouncedInput in FilterBar as it's causing Playwright test failures where links briefly aren't clickable. Doing the debouncing directly in FilterBar eliminates the issue.

Delete DebouncedInput component completely

82de993

No longer used anywhere

rmunn linked an issue May 15, 2025 that may be closed by this pull request

Flaky Playwright tests #1661

Closed

rmunn mentioned this pull request May 15, 2025

Fix flaky Playwright tests by getting rid of DebouncedInput #1666

Closed

rmunn self-assigned this May 15, 2025

hahn-kev requested a review from myieye May 15, 2025 07:30

myieye approved these changes May 15, 2025

View reviewed changes

hahn-kev merged commit 6e3248a into develop May 16, 2025
17 checks passed

hahn-kev deleted the fix-debounced-input-cycles branch May 16, 2025 02:50

Uh oh!

Uh oh!

Conversation

hahn-kev commented May 14, 2025

Uh oh!

coderabbitai Bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UI unit Tests

Uh oh!

github-actions Bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

C# Unit Tests

Uh oh!

rmunn commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmunn commented May 15, 2025

Uh oh!

myieye commented May 15, 2025

Uh oh!

myieye left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented May 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented May 14, 2025 •

edited

Loading

github-actions Bot commented May 14, 2025 •

edited

Loading

rmunn commented May 15, 2025 •

edited

Loading