Skip to content

Remove server-side beta FF check on sync-controller#1722

Merged
myieye merged 1 commit into
developfrom
make-ff-only-apply-to-lexbox-ui
Jun 4, 2025
Merged

Remove server-side beta FF check on sync-controller#1722
myieye merged 1 commit into
developfrom
make-ff-only-apply-to-lexbox-ui

Conversation

@myieye

@myieye myieye commented Jun 3, 2025

Copy link
Copy Markdown
Collaborator

With this change, non-beta users can access and use the full feature-set of the sync dialog.

See: https://sil-language-software.slack.com/archives/CGDKZ7NTV/p1748485267548119?thread_ts=1748462102.699679&cid=CGDKZ7NTV

Here's my no-beta-access user currently doing a Send/Receive:
image

@coderabbitai

coderabbitai Bot commented Jun 3, 2025

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The [FeatureFlagRequired(FeatureFlag.FwLiteBeta, AllowAdmin = true)] attribute was removed from the SyncController class in the backend API. No other logic or functionality within the controller was altered.

Changes

File(s) Change Summary
backend/LexBoxApi/Controllers/SyncController.cs Removed the [FeatureFlagRequired(FeatureFlag.FwLiteBeta, AllowAdmin = true)] attribute from the SyncController class.

Poem

A flag once guarded Sync’s domain,
But now its watchful post is lain.
The code is lighter, free to run,
No feature gate to block the fun!
With every hop, the rabbit cheers—
For simpler code in future years.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cdf24d and f0dbb19.

📒 Files selected for processing (1)
  • backend/LexBoxApi/Controllers/SyncController.cs (0 hunks)
💤 Files with no reviewable changes (1)
  • backend/LexBoxApi/Controllers/SyncController.cs
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build API / publish-api
  • GitHub Check: Analyze (csharp)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

C# Unit Tests

116 tests  ±0   116 ✅ ±0   10s ⏱️ ±0s
 17 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f0dbb19. ± Comparison against base commit 8cdf24d.

@myieye myieye merged commit c8b1daf into develop Jun 4, 2025
11 checks passed
@myieye myieye deleted the make-ff-only-apply-to-lexbox-ui branch June 4, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants