Allow downloading projects that match fwdata project

[myieye]

I coudn't download a project using the fancy admin download-by-code feature, because I had a fwdata project with that name (because fwdata projects are in localProjects).

[coderabbitai]

📝 Walkthrough

Walkthrough

Introduces explanatory comments in CombinedProjectsService and updates Server.svelte’s validateCodeForDownload to require both matching project code and server ID when checking for already-downloaded projects. No public API changes.

Changes

Cohort / File(s)	Summary
Backend: Comments in CombinedProjectsService backend/FwLite/FwLiteShared/Projects/CombinedProjectsService.cs	Added two comments clarifying cross-server project origins and uniqueness of project codes; no logic changes.
Frontend: Download validation update frontend/viewer/src/home/Server.svelte	Modified validateCodeForDownload to consider a project “already downloaded” only if code and server.id both match: from p.code === projectCode to p.code === projectCode && p.server?.id === server?.id.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Allow admins (site or org) to download projects by code #1829 — Also adjusts validateCodeForDownload and references the same backend area, suggesting overlapping intent.

Suggested reviewers

• rmunn
• hahn-kev

Poem

A bunny tapped the server’s door,
“Same code? Not sure—let’s check once more!”
With twitching nose it matched the ID,
Two keys aligned: code, server—see?
Backend whispers notes so clear,
Hop-safe downloads, burrow-near. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-downloading-projects-with-used-fwdata-code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

UI unit Tests

  1 files   40 suites   22s ⏱️
 82 tests  82 ✅ 0 💤 0 ❌
116 runs  116 ✅ 0 💤 0 ❌

Results for commit a75dfe4.

♻️ This comment has been updated with latest results.

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Aug 18, 2025, 10:14 AM

[github-actions]

C# Unit Tests

130 tests  ±0   130 ✅ ±0   19s ⏱️ -1s
 20 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a75dfe4. ± Comparison against base commit 2a4ea85.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

backend/FwLite/FwLiteShared/Projects/CombinedProjectsService.cs (1)

167-169: Minor grammar fix in comment

Nit: “current only relevant” → “currently only relevant”.

-                // Note: the project might be from a different server, but that's current only relevant for devs
+                // Note: the project might be from a different server, but that's currently only relevant for devs
                 // and we still can't download two projects with the same code

frontend/viewer/src/home/Server.svelte (1)

84-86: Block duplicate CRDT downloads by code in validateCodeForDownload

The backend rejects any CRDT project with the same code across servers, but the current client check only blocks when the server IDs match. To keep the UI in sync and avoid a backend‐side ProjectAlreadyDownloaded error, narrow the check to CRDT projects by code:

-    if (localProjects.some(p => p.code === projectCode && p.server?.id === server?.id)) {
+    if (localProjects.some(p => p.code === projectCode && p.crdt)) {
       return $t`You have already downloaded the ${projectCode} project`;
     }

• Ensure your Project interface includes a crdt: boolean flag.
• This also removes reliance on server?.id, handling cases when server is undefined.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2a4ea85 and a75dfe4.

📒 Files selected for processing (2)

• backend/FwLite/FwLiteShared/Projects/CombinedProjectsService.cs (1 hunks)
• frontend/viewer/src/home/Server.svelte (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: Build API / publish-api
• GitHub Check: Build UI / publish-ui
• GitHub Check: check-and-lint
• GitHub Check: Analyze (csharp)
• GitHub Check: frontend
• GitHub Check: Build FW Lite and run tests
• GitHub Check: frontend-component-unit-tests