change how durations are formatted to be i18n friendly#1968
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughLocalization updates across English, Spanish, French, Indonesian, and Korean PO files: introduce "# ago" and "# before", remove "ago" and "before", add "Synced {0} ago" (context shifts to ActivityView), adjust "Synced" contexts, and add "Synchronize" (EN) and "a word" (ID). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (12)
frontend/viewer/src/locales/es.po (3)
65-69: Translate '# ago' to match Spanish word order ('hace #').Empty msgstr will fall back to English. Use preposed 'hace' to allow correct reordering.
-msgstr "" +msgstr "hace #"
70-74: Translate '# before' for Spanish.Use '# antes' (e.g., '3 días antes'). Keeps '#' placeholder position intact.
-msgstr "" +msgstr "# antes"
1015-1018: Provide Spanish for 'Synced {0} ago'.Natural phrasing places 'hace' before the duration.
-msgstr "" +msgstr "Sincronizado hace {0}"frontend/viewer/src/locales/fr.po (3)
65-69: Fill FR translation for '# ago'.Standard French is 'il y a #'.
-msgstr "" +msgstr "il y a #"
70-74: Fill FR translation for '# before'.Use '# avant' (e.g., '3 jours avant').
-msgstr "" +msgstr "# avant"
1015-1018: Translate 'Synced {0} ago' to French.Matches common UI phrasing.
-msgstr "" +msgstr "Synchronisé il y a {0}"frontend/viewer/src/locales/id.po (3)
65-69: Add ID translation for '# ago'.Use '# yang lalu' (e.g., '5 menit yang lalu').
-msgstr "" +msgstr "# yang lalu"
70-74: Add ID translation for '# before'.Use '# sebelumnya' (e.g., '3 hari sebelumnya').
-msgstr "" +msgstr "# sebelumnya"
1015-1018: Translate 'Synced {0} ago' to Indonesian.-msgstr "" +msgstr "Disinkronkan {0} yang lalu"frontend/viewer/src/locales/ko.po (3)
65-69: Provide KO translation for '# ago'.Korean uses a postposition; include a space: '# 전' (e.g., '5분 전').
-msgstr "" +msgstr "# 전"
70-74: Provide KO translation for '# before'.Same rendering as 'ago' in Korean.
-msgstr "" +msgstr "# 전"
1015-1018: Translate 'Synced {0} ago' to Korean.-msgstr "" +msgstr "{0} 전에 동기화됨"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
frontend/viewer/src/locales/en.po(2 hunks)frontend/viewer/src/locales/es.po(2 hunks)frontend/viewer/src/locales/fr.po(2 hunks)frontend/viewer/src/locales/id.po(2 hunks)frontend/viewer/src/locales/ko.po(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build API / publish-api
- GitHub Check: Build UI / publish-ui
- GitHub Check: Build FW Lite and run tests
- GitHub Check: frontend-component-unit-tests
- GitHub Check: check-and-lint
🔇 Additional comments (1)
frontend/viewer/src/locales/en.po (1)
1010-1013: LGTM: 'Synced {0} ago' is clear and consistent with the new pattern.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Danny pointed out some of our duration formats can't be correctly localized due to word order differences.
This fixes the 2 that he found and one that I came across while making the changes, but there could be others.