Skip to content

New Crowdin updates#2181

Merged
myieye merged 61 commits into
developfrom
l10n_develop
May 28, 2026
Merged

New Crowdin updates#2181
myieye merged 61 commits into
developfrom
l10n_develop

Conversation

@myieye

@myieye myieye commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Feb 24, 2026
@coderabbitai

coderabbitai Bot commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4322e720-ad92-4574-aac1-dd6caa396fe2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR adds new validation message translations across eight locale files (English, Spanish, French, Indonesian, Korean, Malay, Swahili, and Vietnamese) for the NewEntryDialog component, introducing required-field validation messages for definition, lexeme form, and word inputs.

Changes

Cohort / File(s) Summary
Internationalization - NewEntryDialog Validations
frontend/viewer/src/locales/en.po, frontend/viewer/src/locales/es.po, frontend/viewer/src/locales/fr.po, frontend/viewer/src/locales/id.po, frontend/viewer/src/locales/ko.po, frontend/viewer/src/locales/ms.po, frontend/viewer/src/locales/sw.po, frontend/viewer/src/locales/vi.po		 Added three new validation message translations: "Definition or Gloss is required", "Lexeme form or Citation form is required", and "Word or Display as is required" across all locales. Updated PO-Revision-Date metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

💻 FW Lite

Suggested reviewers

  • hahn-kev
  • imnasnainaec

Poem

🐰 A rabbit hops through translations so fine,
Adding validation messages in every line,
From Spanish to Swahili, Indonesian to French,
Eight locales blessed, validation's on the bench!
Required fields now whisper across the globe,
In every tongue, users' paths are strobed. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, which is a significant omission for a pull request that updates translation files across 8 different locales. Add a description explaining the purpose of these translation updates and why these specific validation messages were added to the NewEntryDialog component.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'New Crowdin updates' accurately describes the main change—adding new internationalization entries across multiple locale files (en.po, es.po, fr.po, id.po, ko.po, ms.po, sw.po, vi.po) from Crowdin translations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch l10n_develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

myieye added 20 commits March 6, 2026 16:32
myieye added 14 commits May 13, 2026 12:12
rmunn
rmunn approved these changes May 15, 2026
View reviewed changes

@rmunn rmunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once merge conflicts are resolved.

myieye and others added 5 commits May 28, 2026 12:55
@myieye
New translations en.po (Vietnamese)
76c022f 
[ci skip]
@myieye
New translations en.po (Malay)
a18f29c 
[ci skip]
@myieye
New translations en.po (Swahili)
af83b48 
[ci skip]
@myieye
Merge develop into l10n_develop and reconcile catalogs
ea2b908
@myieye
Apply translation fixes from review pass
e8515fa 
Brand-name decomposition fixes (sw): Lexbox, FieldWorks
Abbreviation decomposition fix (sw): MB
Plus 18 other corrections across es/fr/id/ko/ms/sw/vi.
@github-actions

github-actions Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

UI unit Tests

10 tests   10 ✅  0s ⏱️
 3 suites   0 💤
 1 files     0 ❌

Results for commit cad0a8d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

C# Unit Tests

165 tests   165 ✅  21s ⏱️
 23 suites    0 💤
  1 files      0 ❌

Results for commit cad0a8d.

♻️ This comment has been updated with latest results.

@myieye
Backfill translator context for 49 msgids
cad0a8d 
One-time catch-up: added #. context comments to msgids in en.po that
predated the /crowdin-merge skill's context step. With the skill in
consistent use going forward, this kind of backfill should never be
needed again.

Comments propagated to all 7 locales via pnpm i18n:extract.
@argos-ci

argos-ci Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Awaiting the start of a new Argos build…

@myieye myieye force-pushed the l10n_develop branch 2 times, most recently from 25bf321 to cad0a8d Compare May 28, 2026 12:57
@myieye myieye merged commit 607b171 into develop May 28, 2026
43 of 48 checks passed
@myieye myieye deleted the l10n_develop branch May 28, 2026 12:58
@myieye myieye mentioned this pull request May 28, 2026
Merged
myieye added a commit that referenced this pull request Jun 3, 2026
@myieye
Add /crowdin-merge skill and clean up deprecated i18n artifacts
1792192 
Adds a Claude Code skill that resolves Crowdin's auto-generated
l10n_develop PR end-to-end: merge develop in, reconcile catalogs to
current code, review incoming translations with a per-locale Sonnet
agent (catching brand-name decomposition, broken placeholders,
meaning inversions, and similar bug classes), apply fixes, surface a
report with per-edit reasoning, and on approval push translations
and the branch.

Includes a context-writer subagent that adds translator-context
#. comments to new msgids in en.po per the project's
I18N_CONTEXT_GUIDE.md.

Validated end-to-end on PR #2181 (already merged): caught real
MT failures including sw "Lexbox" → "Sanduku la maneno" and
sw "{0} MB" → "{0} Mama/Baba", applied 22 corrections across
7 locales, surfaced 29 items for human review.

Removes the older prompt-file approach (.github/prompts/) and
the review-po.js batching script, superseded by the skill.
Trims crowdin/Taskfile.yml to the tasks the skill actually uses;
rewrites crowdin/README.md to match today's reality (Crowdin's
GitHub integration is export-only; MT covers all 7 locales).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmunn rmunn rmunn approved these changes

Assignees

No one assigned

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📙 Platform.Bible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@myieye @rmunn