Fix missing i18n placeholders in OpenInFlexModal#2269
Conversation
The instructions_flex translation expects {login}, {code}, {name} but the
modal only passed code and name, leaving login blank. Also pass isEmpty
to instructions_header so the select branches resolve correctly.
…polation
svelte-intl-precompile compiles ICU messages into positional functions
where caller-supplied keys are sorted alphabetically and applied
positionally. If a caller omits a placeholder or its name doesn't match
exactly, values silently shift between parameters. That was making the
type select fall into the 'other' branch ("(e.g.) FieldWorks") even
for FlEx projects.
Pre-compute the app display name in the caller and just interpolate
{appName}, so the message no longer depends on the GraphQL enum value
matching an ICU select key.
…me interpolation" This reverts commit 5dc1bd2.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
UI unit Tests 1 files ± 0 3 suites - 56 0s ⏱️ -30s Results for commit 901487e. ± Comparison against base commit 9d47e7e. This pull request removes 176 and adds 10 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
The instructions_flex translation expects {login}, {code}, {name} but the modal only passed code and name, leaving login blank.
Also pass isEmpty to instructions_header so the select branches resolve correctly.
Before: (wrong login. Blank folder-name suggestion)

After:
