Skip to content

Fix missing i18n placeholders in OpenInFlexModal#2269

Merged
myieye merged 3 commits into
developfrom
claude/fix-i18n-placeholders-AeVjk
May 15, 2026
Merged

Fix missing i18n placeholders in OpenInFlexModal#2269
myieye merged 3 commits into
developfrom
claude/fix-i18n-placeholders-AeVjk

Conversation

@myieye

@myieye myieye commented May 15, 2026

Copy link
Copy Markdown
Collaborator

The instructions_flex translation expects {login}, {code}, {name} but the modal only passed code and name, leaving login blank.
Also pass isEmpty to instructions_header so the select branches resolve correctly.

Before: (wrong login. Blank folder-name suggestion)
image

After:
image

claude added 3 commits May 15, 2026 12:20
The instructions_flex translation expects {login}, {code}, {name} but the
modal only passed code and name, leaving login blank. Also pass isEmpty
to instructions_header so the select branches resolve correctly.
…polation

svelte-intl-precompile compiles ICU messages into positional functions
where caller-supplied keys are sorted alphabetically and applied
positionally. If a caller omits a placeholder or its name doesn't match
exactly, values silently shift between parameters. That was making the
type select fall into the 'other' branch ("(e.g.) FieldWorks") even
for FlEx projects.

Pre-compute the app display name in the caller and just interpolate
{appName}, so the message no longer depends on the GraphQL enum value
matching an ICU select key.
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@myieye has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 41 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 842e2a7e-c9a2-4f34-8991-18c44771f989

📥 Commits

Reviewing files that changed from the base of the PR and between 9d47e7e and 901487e.

📒 Files selected for processing (2)
  • frontend/src/routes/(authenticated)/project/[project_code]/+page.svelte
  • frontend/src/routes/(authenticated)/project/[project_code]/OpenInFlexModal.svelte
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-i18n-placeholders-AeVjk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the 📦 Lexbox issues related to any server side code, fw-headless included label May 15, 2026
@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

UI unit Tests

 1 files  ±  0   3 suites   - 56   0s ⏱️ -30s
10 tests  - 166  10 ✅  - 166  0 💤 ±0  0 ❌ ±0 
10 runs   - 235  10 ✅  - 235  0 💤 ±0  0 ❌ ±0 

Results for commit 901487e. ± Comparison against base commit 9d47e7e.

This pull request removes 176 and adds 10 tests. Note that renamed tests count towards both.
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > accepts parent values when not dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > does NOT guard against stomping deep changes, because StompGuard can't detect them
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > ignores parent values when dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > initializes with the parent value
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > keeps subscribers up to date when it becomes dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > pushs changes to parent
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > reverts new parent values when ignored
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > starts accepting parent changes again after a flush
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations with smallest unit
…
src/index.test.ts ‑ password hashing > can hash a pw using sha1
src/lib/i18n/i18n.test.ts ‑ buildRegionalLocaleRegex > should find all regional locales for available locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en by default
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en if no user locale is provided and acceptLanguageHeader does not have any supported locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return regional locale from acceptLanguageHeader if it has a higher quality rating than the regionless locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return supported locale from acceptLanguageHeader with highest quality rating if no user locale is provided
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale with a higher quality rating
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader is not provided
src/lib/user.test.ts ‑ jwtToUser > should convert a jwt token to a LexAuthUser

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

C# Unit Tests

165 tests  ±0   165 ✅ ±0   20s ⏱️ -1s
 23 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 901487e. ± Comparison against base commit 9d47e7e.

♻️ This comment has been updated with latest results.

@myieye myieye marked this pull request as ready for review May 15, 2026 13:55
@myieye myieye merged commit cf65ff0 into develop May 15, 2026
23 checks passed
@myieye myieye deleted the claude/fix-i18n-placeholders-AeVjk branch May 15, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants