Skip to content

Fix Send/Receive URL domain and copy button styling#2270

Merged
myieye merged 1 commit into
developfrom
claude/fix-domain-copy-button-SXAxS
May 18, 2026
Merged

Fix Send/Receive URL domain and copy button styling#2270
myieye merged 1 commit into
developfrom
claude/fix-domain-copy-button-SXAxS

Conversation

@myieye

@myieye myieye commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Use canonical hg-public.languageforge.org (and hg-staging.languageforge.org) instead of deriving from page host, which produced broken hg-public.lexbox.org. Forward a join prop through CopyToClipboardButton so the button renders as a proper join-item next to the input.

Before:
image

After:
image

image

(I can't demonstrate the prod URL, but it's now just hardcoded).

Use canonical hg-public.languageforge.org (and hg-staging.languageforge.org)
instead of deriving from page host, which produced broken hg-public.lexbox.org.
Forward a join prop through CopyToClipboardButton so the button renders as
a proper join-item next to the input.
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ca7c7076-18bb-4436-ad04-b3f60bfff9b9

📥 Commits

Reviewing files that changed from the base of the PR and between 9d47e7e and 865d26e.

📒 Files selected for processing (2)
  • frontend/src/lib/components/CopyToClipboardButton.svelte
  • frontend/src/routes/(authenticated)/project/[project_code]/SendReceiveUrlField.svelte

📝 Walkthrough

Walkthrough

The PR adds a join prop to CopyToClipboardButton to enable joined styling with input fields, updates SendReceiveUrlField to use this new prop, and replaces dynamic hostname substitution with fixed Languageforge domain URLs for staging and public environments.

Changes

Send/Receive URL form styling

Layer / File(s) Summary
CopyToClipboardButton join prop
frontend/src/lib/components/CopyToClipboardButton.svelte
Props interface adds optional join field with default false; the prop is passed through to both IconButton instances in copied and default states.
SendReceiveUrlField integration and hostname configuration
frontend/src/routes/(authenticated)/project/[project_code]/SendReceiveUrlField.svelte
projectHgUrl now uses fixed hg-staging.languageforge.org and hg-public.languageforge.org hostnames; CopyToClipboardButton receives the new join prop for consistent joined styling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

💻 FW Lite

Poem

🐰 A button joins the input's dance,
With styles that now align,
And hostnames fixed in their advance—
Small tweaks that make things shine!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-domain-copy-button-SXAxS

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the 📦 Lexbox issues related to any server side code, fw-headless included label May 15, 2026
@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

UI unit Tests

 1 files  ±  0   3 suites   - 56   0s ⏱️ -30s
10 tests  - 166  10 ✅  - 166  0 💤 ±0  0 ❌ ±0 
10 runs   - 235  10 ✅  - 235  0 💤 ±0  0 ❌ ±0 

Results for commit 865d26e. ± Comparison against base commit 9d47e7e.

This pull request removes 176 and adds 10 tests. Note that renamed tests count towards both.
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > accepts parent values when not dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > does NOT guard against stomping deep changes, because StompGuard can't detect them
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > ignores parent values when dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > initializes with the parent value
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > keeps subscribers up to date when it becomes dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > pushs changes to parent
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > reverts new parent values when ignored
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > starts accepting parent changes again after a flush
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations with smallest unit
…
src/index.test.ts ‑ password hashing > can hash a pw using sha1
src/lib/i18n/i18n.test.ts ‑ buildRegionalLocaleRegex > should find all regional locales for available locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en by default
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en if no user locale is provided and acceptLanguageHeader does not have any supported locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return regional locale from acceptLanguageHeader if it has a higher quality rating than the regionless locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return supported locale from acceptLanguageHeader with highest quality rating if no user locale is provided
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale with a higher quality rating
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader is not provided
src/lib/user.test.ts ‑ jwtToUser > should convert a jwt token to a LexAuthUser

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

C# Unit Tests

165 tests  ±0   165 ✅ ±0   20s ⏱️ -1s
 23 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 865d26e. ± Comparison against base commit 9d47e7e.

♻️ This comment has been updated with latest results.

@myieye myieye marked this pull request as ready for review May 18, 2026 12:14
@myieye myieye merged commit d4d5cef into develop May 18, 2026
31 of 32 checks passed
@myieye myieye deleted the claude/fix-domain-copy-button-SXAxS branch May 18, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants