Show all root fields in Update-entry-dialog#2273
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR introduces ChangesRoot Fields View Scoping
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
RootFields now spreads currentView (so its writing-system selection is kept) and only overrides the field arrays with the root view's, matching the pattern already used by OverrideFields. NewEntryDialog now wraps its editor in RootFields instead of an OverrideFields with a hand-picked shownFields list, so the create-entry dialog shows all root fields while still respecting the WS selection of the currently selected custom-view.
Without this, the update-entry-dialog that is accessible when reviewing entries touched during a task, might not include the fields and/or writing-systems that were used by the task. (i.e. if the currently selected custom-view doesn't include them).