Skip to content

Show all root fields in Update-entry-dialog#2273

Open
myieye wants to merge 2 commits into
developfrom
show-all-fields-in-edit-entry-dialog
Open

Show all root fields in Update-entry-dialog#2273
myieye wants to merge 2 commits into
developfrom
show-all-fields-in-edit-entry-dialog

Conversation

@myieye
Copy link
Copy Markdown
Collaborator

@myieye myieye commented May 18, 2026

Without this, the update-entry-dialog that is accessible when reviewing entries touched during a task, might not include the fields and/or writing-systems that were used by the task. (i.e. if the currently selected custom-view doesn't include them).

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label May 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f67287e7-0b3c-4be2-b3d8-4f0bacf863b1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR introduces RootFields, a new Svelte component that manages view service overrides for field editing scope, and integrates it into EditEntryDialog. RootFields sets up a separate override service configured with persistence disabled and synchronizes it with a root view context before rendering child components.

Changes

Root Fields View Scoping

Layer / File(s) Summary
RootFields component with view service override
frontend/viewer/src/lib/views/RootFields.svelte
Creates RootFields component that initializes a viewService and overrideService (with persist: false), uses $effect.pre to set overrideService.view to viewService.rootView, and renders optional children via a Snippet prop.
EditEntryDialog wrapped in RootFields
frontend/viewer/src/lib/entry-editor/EditEntryDialog.svelte
Imports RootFields and wraps EntryEditor within it, changing field-scoping context from the dialog's default container to root view.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • sillsdev/languageforge-lexbox#2272: Updates OverrideFields to derive overrides from currentView instead of rootView, working in tandem with this PR's introduction of root view scoping mechanics.

Suggested labels

💻 FW Lite

Poem

🐰 A new fields component hops into view,
With root-level scoping—a fresh way to do.
Services aligned in a synchronized dance,
The editor now bound by a root-focused glance.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: wrapping EntryEditor with RootFields to show all root fields in the update-entry-dialog.
Description check ✅ Passed The description directly relates to the changeset by explaining the problem being solved: ensuring all root fields are shown in the update-entry-dialog regardless of the currently selected custom-view.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch show-all-fields-in-edit-entry-dialog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

UI unit Tests

  1 files  ±0   59 suites  ±0   29s ⏱️ -2s
176 tests ±0  176 ✅ ±0  0 💤 ±0  0 ❌ ±0 
245 runs  ±0  245 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 65d43d7. ± Comparison against base commit 52ae636.

♻️ This comment has been updated with latest results.

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented May 18, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - May 21, 2026, 7:05 AM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

C# Unit Tests

165 tests  ±0   165 ✅ ±0   20s ⏱️ ±0s
 23 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 65d43d7. ± Comparison against base commit 52ae636.

♻️ This comment has been updated with latest results.

@myieye myieye requested a review from rmunn May 18, 2026 15:16
RootFields now spreads currentView (so its writing-system selection is
kept) and only overrides the field arrays with the root view's, matching
the pattern already used by OverrideFields.

NewEntryDialog now wraps its editor in RootFields instead of an
OverrideFields with a hand-picked shownFields list, so the create-entry
dialog shows all root fields while still respecting the WS selection of
the currently selected custom-view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant