Skip to content

Simplify to rely on Harmony's duplicate commit handling #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myieye merged 1 commit into from
May 27, 2026
Merged

Simplify to rely on Harmony's duplicate commit handling #2277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions backend/FwLite/LcmCrdt/CurrentProjectService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,9 @@ async Task Execute()

// Seed morph-types if missing (for existing projects created before morph-type support).
// Must happen BEFORE FTS regeneration so headwords include morph-type tokens.
// (querying Commits instead of MorphTypes, because the commit may not be projected yet)
var dataModel = services.GetRequiredService<DataModel>();

@hahn-kev hahn-kev May 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to introduce a version on Project data so that we can only do these kinds of migrations when the version is older. It might not be too bad now, but when we have more of these migrations it'll start to add up quickly, and being able to do a simple comparison against a version number will let us short circuit a lot of checks.

var projectData = await dbContext.ProjectData.AsNoTracking().FirstAsync();
if (!await dbContext.Set<Commit>().AsNoTracking().AnyAsync(c => c.Id == PreDefinedData.MorphTypesSeedCommitId(projectData.Id)))
{
var dataModel = services.GetRequiredService<DataModel>();
await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData);
}
await PreDefinedData.AddPredefinedMorphTypes(dataModel, projectData);

if (EntrySearchServiceFactory is not null)
{
Expand Down
Loading