Fix issue loading tasks as starting page by hahn-kev · Pull Request #2352 · sillsdev/languageforge-lexbox

hahn-kev · 2026-06-12T07:01:59Z

On my phone the tasks page is cached as the starting page and there's a JS error because the project is not ready. This caused me to be stuck on the page. I fixed the root cause and provided a failsafe.

#2316 provided one failsafe. This PR provides another using a svelte:boundary to catch render errors and provide a way to try again or close the project or open the sidebar.

Forcing an error to happen when rendering the tasks view looks like this:

it's a little weird to have the sidebar toggle twice, but it doesn't hurt. The new error handler is also used on the Browse View, but I didn't force an error to test that version.

…t context availability

…TasksView

coderabbitai · 2026-06-12T07:02:11Z

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 09548682-e647-480c-b640-4d544c11eb1a

📥 Commits

Reviewing files that changed from the base of the PR and between 78e3f97 and 3bb0d26.

📒 Files selected for processing (13)

frontend/viewer/src/lib/errors/global-errors.ts
frontend/viewer/src/lib/layout/ViewErrorBoundary.svelte
frontend/viewer/src/locales/en.po
frontend/viewer/src/locales/es.po
frontend/viewer/src/locales/fr.po
frontend/viewer/src/locales/id.po
frontend/viewer/src/locales/ko.po
frontend/viewer/src/locales/ms.po
frontend/viewer/src/locales/sw.po
frontend/viewer/src/locales/vi.po
frontend/viewer/src/project/browse/BrowseView.svelte
frontend/viewer/src/project/tasks/TaskView.svelte
frontend/viewer/src/project/tasks/TasksView.svelte

📝 Walkthrough

Walkthrough

This PR introduces a structured error boundary system across the viewer frontend. The error handler now accepts plain Error objects alongside browser events, a new ViewErrorBoundary component provides error fallback UI with localized messages and recovery actions, and the component is integrated into browse and task views. A conditional rendering fix in TaskView prevents UI interaction when the API is unavailable.

Changes

Error Boundary System

Layer / File(s)	Summary
Error handler contract and unification `frontend/viewer/src/lib/errors/global-errors.ts`	`unifyErrorEvent` handles plain `Error` objects, and `onErrorEvent` is exported with a widened type signature to accept `ErrorEvent`, `PromiseRejectionEvent`, or `Error`.
ViewErrorBoundary component `frontend/viewer/src/lib/layout/ViewErrorBoundary.svelte`	New Svelte component with typed props (`children`, optional `title`, optional `class`), error normalization via `onError`, and a `<svelte:boundary>` wrapper that renders localized destructive alert fallback with retry and home-navigation buttons.
Localization for error UI `frontend/viewer/src/locales/{en,es,fr,id,ko,ms,sw,vi}.po`	Error message strings ("Browse view failed", "Task view failed", "Something went wrong", "Try again") added to all eight locale files; English translations provided, non-English entries await translation.
View integration `frontend/viewer/src/project/browse/BrowseView.svelte`, `frontend/viewer/src/project/tasks/TasksView.svelte`	`BrowseView` and `TasksView` wrap main content in `ViewErrorBoundary` with localized error titles, catching errors during browse and task interactions.
TaskView conditional popup rendering `frontend/viewer/src/project/tasks/TaskView.svelte`	`SubjectPopup` is conditionally rendered only when `projectContext.maybeApi` is available, preventing interactions when API is unavailable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

sillsdev/languageforge-lexbox#1863: Adds new locale resource files (ms.po, sw.po) that are updated in this PR with error-state strings.
sillsdev/languageforge-lexbox#1929: Updates translations for the new error UI strings introduced by this PR.

Suggested reviewers

myieye
rmunn

Poem

🐰 Boundaries catch what slips away,
Errors now have something to say,
ViewErrorBoundary saves the day—
With reset buttons and "try again," hooray!
Your views won't crash without a fray. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix issue loading tasks as starting page' directly relates to the PR's main objective of fixing a crash when the tasks page loads as the starting page, which is clearly addressed throughout the changeset.
Description check	✅ Passed	The description clearly explains the problem (tasks page cached as starting page causing JS error) and the solution implemented (root cause fix plus failsafe using svelte:boundary), which aligns with the actual changes in the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-crash-loading-tasks-view-at-startup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-12T07:02:48Z

UI unit Tests

1 files ± 0 3 suites - 59 0s ⏱️ -32s
10 tests - 176 10 ✅ - 176 0 💤 ±0 0 ❌ ±0
10 runs - 248 10 ✅ - 248 0 💤 ±0 0 ❌ ±0

Results for commit 3bb0d26. ± Comparison against base commit 78e3f97.

This pull request removes 186 and adds 10 tests. Note that renamed tests count towards both.

src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > accepts parent values when not dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > does NOT guard against stomping deep changes, because StompGuard can't detect them
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > ignores parent values when dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > initializes with the parent value
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > keeps subscribers up to date when it becomes dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > pushs changes to parent
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > reverts new parent values when ignored
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > starts accepting parent changes again after a flush
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations with smallest unit
…

src/index.test.ts ‑ password hashing > can hash a pw using sha1
src/lib/i18n/i18n.test.ts ‑ buildRegionalLocaleRegex > should find all regional locales for available locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en by default
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en if no user locale is provided and acceptLanguageHeader does not have any supported locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return regional locale from acceptLanguageHeader if it has a higher quality rating than the regionless locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return supported locale from acceptLanguageHeader with highest quality rating if no user locale is provided
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale with a higher quality rating
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader is not provided
src/lib/user.test.ts ‑ jwtToUser > should convert a jwt token to a LexAuthUser

♻️ This comment has been updated with latest results.

github-actions · 2026-06-12T07:04:59Z

C# Unit Tests

165 tests ±0 165 ✅ ±0 21s ⏱️ -1s
23 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit dbace67. ± Comparison against base commit 78e3f97.

♻️ This comment has been updated with latest results.

argos-ci · 2026-06-12T07:11:39Z

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jun 12, 2026, 11:51 AM

so stack trace is shown and copy/pastable

myieye · 2026-06-12T11:50:30Z

I just made it even uglier 😉, by showing an error toast so stack traces are still there and can be copy/pasted:

hahn-kev added 2 commits June 12, 2026 13:46

Enhance TaskView to conditionally render SubjectPopup based on projec…

10524ec

…t context availability

Add ViewErrorBoundary component for error handling in BrowseView and …

7d4a063

…TasksView

github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jun 12, 2026

update i18n files

dbace67

Reuse global error toast

3bb0d26

so stack trace is shown and copy/pastable

myieye approved these changes Jun 12, 2026

View reviewed changes

myieye merged commit 5e415f1 into develop Jun 12, 2026
14 of 15 checks passed

myieye deleted the fix-crash-loading-tasks-view-at-startup branch June 12, 2026 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix issue loading tasks as starting page#2352

Fix issue loading tasks as starting page#2352
myieye merged 4 commits into
developfrom
fix-crash-loading-tasks-view-at-startup

hahn-kev commented Jun 12, 2026

Uh oh!

coderabbitai Bot commented Jun 12, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

argos-ci Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

myieye commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

hahn-kev commented Jun 12, 2026

Uh oh!

coderabbitai Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UI unit Tests

Uh oh!

github-actions Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

C# Unit Tests

Uh oh!

argos-ci Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myieye commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jun 12, 2026 •

edited

Loading

github-actions Bot commented Jun 12, 2026 •

edited

Loading

github-actions Bot commented Jun 12, 2026 •

edited

Loading

argos-ci Bot commented Jun 12, 2026 •

edited

Loading