Use the validation wrapper in MiniLcm API tests#2360
Conversation
The shared MiniLcm test bases now wrap their Api in the same validation/normalization stack production uses, so the tests hit the API the way the app actually does instead of more loosely. Reuses the production AddMiniLcmValidators wiring so new validators flow into tests automatically. One test that deliberately stores an empty value now talks to the raw BaseApi (it checks storage round-tripping, not a real user call, and validation correctly rejects empty values). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 7 minutes and 4 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
💻 FW Lite
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
2 participants
Adds the validation wrapper to a bunch of tests. Most notably everything inheriting from
MiniLcmTestBase.cs.Not having the validation-wrapper in the stack made testing cases that involved validation (e.g. the new
IsMainpublication stuff) awkward, dissatisfying and messy.Also, this validation is essentially part of our API it's just in a wrapper, so that we can easily apply it to multiple implementations.
And then it just makes sense to have an API stack that more closely resembles prod code.