Skip to content

Commit ae3bb0e

Browse files
committed
Add ignore json to word alignment too
1 parent 0ce82ee commit ae3bb0e

3 files changed

Lines changed: 5 additions & 16 deletions

File tree

src/Serval/src/Serval.Client/Client.g.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10996,9 +10996,6 @@ public partial class WordAlignmentBuild
1099610996
[Newtonsoft.Json.JsonProperty("deploymentVersion", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
1099710997
public string? DeploymentVersion { get; set; } = default!;
1099810998

10999-
[Newtonsoft.Json.JsonProperty("executionData", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
11000-
public System.Collections.Generic.IDictionary<string, string>? ExecutionData { get; set; } = default!;
11001-
1100210999
[Newtonsoft.Json.JsonProperty("phases", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
1100311000
public System.Collections.Generic.IList<Phase>? Phases { get; set; } = default!;
1100411001

src/Serval/src/Serval.WordAlignment/Contracts/WordAlignmentBuildDto.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
namespace Serval.WordAlignment.Contracts;
1+
using System.Text.Json.Serialization;
2+
3+
namespace Serval.WordAlignment.Contracts;
24

35
public record WordAlignmentBuildDto
46
{
@@ -31,6 +33,8 @@ public record WordAlignmentBuildDto
3133
/// </example>
3234
public object? Options { get; init; }
3335
public string? DeploymentVersion { get; init; }
36+
37+
[JsonIgnore]
3438
public IReadOnlyDictionary<string, string>? ExecutionData { get; init; }
3539
public IReadOnlyList<PhaseDto>? Phases { get; init; }
3640
}

src/Serval/test/Serval.E2ETests/ServalApiTests.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -523,18 +523,6 @@ public async Task GetWordAlignment()
523523
});
524524

525525
WordAlignmentBuild build = await _helperClient.WordAlignmentEnginesClient.GetBuildAsync(engineId, buildId);
526-
Assert.That(build.ExecutionData, Is.Not.Null);
527-
528-
var executionData = build.ExecutionData;
529-
530-
Assert.That(executionData, Contains.Key("trainCount"));
531-
Assert.That(executionData, Contains.Key("wordAlignCount"));
532-
533-
int trainCount = Convert.ToInt32(executionData["trainCount"], CultureInfo.InvariantCulture);
534-
int wordAlignmentCount = Convert.ToInt32(executionData["wordAlignCount"], CultureInfo.InvariantCulture);
535-
536-
Assert.That(trainCount, Is.GreaterThan(0));
537-
Assert.That(wordAlignmentCount, Is.GreaterThan(0));
538526

539527
IList<Client.WordAlignment> wordAlignments =
540528
await _helperClient.WordAlignmentEnginesClient.GetAllWordAlignmentsAsync(engineId, corpusId);

0 commit comments

Comments
 (0)