Skip to content

Always use target id text when fetching USFM even when using source template #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Enkidu93 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Always use target id text when fetching USFM even when using source template #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c16a20
Always use target id text when fetching USFM even when using source t…
Enkidu93 Jul 8, 2026
3b55ac8
Update tests
Enkidu93 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Serval/src/Serval.Translation/Services/UsfmGenerationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ .. pretranslations
.OrderBy(row => row.Refs[0]),
],
chapters: chapters,
fullName: isSource ? sourceSettings?.FullName : targetSettings?.FullName,
fullName: targetSettings?.FullName,
textBehavior: textBehavior,
paragraphBehavior: paragraphBehavior,
embedBehavior: embedBehavior,
Expand Down
14 changes: 7 additions & 7 deletions src/Serval/test/Serval.Translation.Tests/Services/UsfmGenerationServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public async Task GetUsfmAsync_Source_PreferExisting()
Assert.That(
usfm,
Is.EqualTo(
@"\id MAT - Test1
@"\id MAT - Test2
\c 1
\rem This draft of MAT 1 was generated by AI from Te1 on 1970-01-01 00:00:00Z. It should be reviewed carefully for errors before use. Paragraph break positions were moved to the end of the verse.
\v 1 Chapter 1, verse 1. ""Translated new paragraph""
Expand All @@ -45,7 +45,7 @@ public async Task GetUsfmAsync_Source_PreferPretranslated()
Assert.That(
usfm,
Is.EqualTo(
@"\id MAT - Test1
@"\id MAT - Test2
\c 1
\rem This draft of MAT 1 was generated by AI from Te1 on 1970-01-01 00:00:00Z. It should be reviewed carefully for errors before use. Paragraph break positions were moved to the end of the verse.
\v 1 Chapter 1, verse 1. ""Translated new paragraph""
Expand All @@ -71,7 +71,7 @@ public async Task GetUsfmAsync_Source_OnlyExisting()
Assert.That(
usfm,
Is.EqualTo(
@"\id MAT - Test1
@"\id MAT - Test2
\c 1
\rem This draft of MAT 1 was generated by AI from Te1 on 1970-01-01 00:00:00Z. It should be reviewed carefully for errors before use. Paragraph break positions were moved to the end of the verse.
\v 1
Expand All @@ -97,7 +97,7 @@ public async Task GetUsfmAsync_Source_OnlyPretranslated()
Assert.That(
usfm,
Is.EqualTo(
@"\id MAT - Test1
@"\id MAT - Test2
\c 1
\rem This draft of MAT 1 was generated by AI from Te1 on 1970-01-01 00:00:00Z. It should be reviewed carefully for errors before use. Paragraph break positions were moved to the end of the verse.
\v 1 Chapter 1, verse 1. ""Translated new paragraph""
Expand All @@ -124,7 +124,7 @@ public async Task GetUsfmAsync_Source_PlaceMarkers()
Assert.That(
usfm,
Is.EqualTo(
@"\id MAT - Test1
@"\id MAT - Test2
\c 1
\rem This draft of MAT 1 was generated by AI from Te1 on 1970-01-01 00:00:00Z. It should be reviewed carefully for errors before use. Paragraph break positions were preserved.
\v 1 Chapter 1, verse 1.
Expand Down Expand Up @@ -213,7 +213,7 @@ public async Task GetUsfmAsync_Auto_TargetBookDoesNotExist()
Assert.That(
usfm,
Is.EqualTo(
@"\id MAT - Test1
@"\id MAT - Test2
\c 1
\rem This draft of MAT 1 was generated by AI from Te1 on 1970-01-01 00:00:00Z. It should be reviewed carefully for errors before use. Paragraph break positions were moved to the end of the verse.
\v 1 Chapter 1, verse 1. ""Translated new paragraph""
Expand Down Expand Up @@ -457,7 +457,7 @@ public async Task GetUsfmAsync_StripAllMarkers()
Assert.That(
usfm,
Is.EqualTo(
@"\id MAT - Test1
@"\id MAT - Test2
\c 1
\rem This draft of MAT 1 was generated by AI from Te1 on 1970-01-01 00:00:00Z. It should be reviewed carefully for errors before use. Paragraph breaks were removed.
\v 1 Chapter 1, verse 1. ""Translated new paragraph""
Expand Down
Loading