Fix most-recently-used-entry delete bug (#1296)

This is a follow up PR to #1252 where during QA testing @longrunningprocess discovered a bug whereby deleting an entry caused the MRU cache and URL to not be updated, thereby creating a situation where the app could go to an invalid state.

Addresses testing and comments called out in #1252 

Also contains an unrelated tweak to a GH issue template 😁 

* use editEntryAndScroll() in deleteEntry()

This replaces the low-level setCurrentEntry() method with the higher-level editEntryAndScroll() method that we use to change entry state.  The higher-level method handles URL updating and MRU cache updates among other things.

This fixes a bug where deleting an entry did not update the URL or update the MRU cache, which could result in an error state under certain circumstances.

* check MRU entry actually exists

Add a check to ensure the MRU entry actually exists in the list before setting the entryId.

The previous commit ensures that the MRU cache is updated upon deleting an entry, so I'm not 100% sure that this check is needed, but it shouldn't hurt, so I think it's safe to add as a precaution against an invalid state.

* tweak S/R GH issue template

Author: megahirt

.github/ISSUE_TEMPLATE/send-receive-with-flex.md

@@ -9,7 +9,7 @@ assignees: ''
 
 If your project has been put on hold and you want to keep the details of your project private, please email languageforgeissues@sil.org with the following information.
 
-The Language Forge project is run as an open-source and open-issue-tracker project, meaning that all our code and issues are publicly available on the internet.  Information you submit below should not container private or personal information.
+The Language Forge project is run as an open-source and open-issue-tracker project, meaning that all our code and issues are publicly available on the internet.  Please do not include any sensitive information (passwords, names, locations, etc.) in this issue report.
 
 
 Project name:

src/angular-app/languageforge/lexicon/editor/editor.component.ts

@@ -528,7 +528,7 @@ export class LexiconEditorController implements angular.IController {
         if (iShowList !== 0) {
           iShowList--;
         }
-        this.setCurrentEntry(this.visibleEntries[iShowList]);
+        this.editEntryAndScroll(this.visibleEntries[iShowList].id);
       } else {
         this.returnToList();
       }
@@ -982,7 +982,7 @@ export class LexiconEditorController implements angular.IController {
 
             // see if there is a most-recently viewed entry in the cache
             await this.offlineCacheUtils.getProjectMruEntryData().then(data => {
-              if(data && data.mruEntryId){
+              if(data && data.mruEntryId && this.editorService.getIndexInList(data.mruEntryId, this.entries) != null){
                 entryId = data.mruEntryId;
               }