e2e test GHA workflow + unit test reporter (#1278)

This PR adds a separate workflow for e2e test runs. The e2e tests could have been included in the existing unit-test workflow, however I chose to split it out into a separate workflow so that it can be reported as a separate line item in the PR checks.

This PR also makes the following minor changes:

adds a unit test reporter to display test results in a PR comment
adds the protractor-fail-fast capability for e2e tests (stop test runner after first failure).
This is advantageous for E2E tests since they take a long time to run, and often the first failing test is where the problem lies.
This should save time when running flaky E2E tests. We should be able to re-run the e2e tests quicker with fail-fast turned on.

Fixes #1276
Fixes #1269

Author: megahirt

.github/workflows/e2e-tests.yml

@@ -0,0 +1,23 @@
+name: Run E2E Tests
+
+# https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#on
+on:
+  pull_request:
+
+defaults:
+  run:
+    shell: bash
+    working-directory: docker
+
+jobs:
+  e2e-tests:
+    runs-on: ubuntu-latest
+
+    env:
+      DOCKER_BUILDKIT: 1
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Run E2E Tests
+        run: make e2e-tests

.github/workflows/unit-tests.yml

@@ -1,12 +1,13 @@
-name: Run unit tests
+name: Run Unit Tests
 
 # https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#on
 on:
   pull_request:
 
-  push:
-    branches:
-      - staging
+defaults:
+  run:
+    shell: bash
+    working-directory: docker
 
 jobs:
   unit-tests:
@@ -16,7 +17,15 @@ jobs:
       - uses: actions/checkout@v2
       - uses: satackey/action-docker-layer-caching@v0.0.11
 
-      - name: Run unit tests
-        working-directory: ./docker/
-        run: make unit-tests
+      - name: Run Unit Tests
+        run: make unit-tests-ci
 
+      - name: echo working directory contents
+        run: ls -l
+
+      - name: Publish Test Results
+        uses: docker://ghcr.io/enricomi/publish-unit-test-result-action:v1
+        if: always()
+        with:
+          github_token: ${{ github.token }}
+          files: docker/PhpUnitTests.xml

docker/Makefile

@@ -26,6 +26,12 @@ unit-tests:
 	docker-compose build test-php
 	docker-compose run test-php
 
+.PHONY: unit-tests-ci
+unit-tests-ci: build
+	docker-compose build test-php
+	docker-compose run --name unittests test-php
+	docker cp unittests:/var/www/PhpUnitTests.xml .
+
 .PHONY: build
 build:
 	docker-compose build mail app ld-api