Fix registry password template

Author: johannes-graner

codehub/cli/helm/create.py

@@ -42,7 +42,10 @@ def admin_to_yaml_str(admin):
     placeholder_replacements["SUDOERS"] = " ".join(admins)
 
     placeholder_replacements["REGISTRY_HOSTNAME"] = cloud_state.docker_registry_hostname
-    placeholder_replacements["REGISTRY_PASSWORD"] = cloud_state.hub_sa_key
+    # The spaces after newline are important for the indentation in the yaml file
+    placeholder_replacements["REGISTRY_PASSWORD"] = cloud_state.hub_sa_key.replace(
+        "\n", "\n    "
+    )
     placeholder_replacements["DOCKER_IMAGE"] = cloud_state.docker_image
 
     if "DOCKER_IMAGE_TAG" not in placeholder_replacements:

codehub/templates/hub/imagePullSecrets.yaml

@@ -8,8 +8,9 @@ imagePullSecret:
   registry: {{REGISTRY_HOSTNAME}}
   username: {{REGISTRY_USERNAME}}
   email: {{REGISTRY_EMAIL}}
-  password: {{REGISTRY_PASSWORD}}
+  password: |-
+    {{REGISTRY_PASSWORD}}
 
 # imagePullSecrets is configuration to reference the k8s Secret resources the
 # Helm chart's pods can get credentials from to pull their images.
-imagePullSecrets: ['{{IMAGE_PULL_SECRET}}']
+imagePullSecrets: ['{{IMAGE_PULL_SECRET}}']