Skip to content

Commit 6baea3b

Browse files
committed
Add Geometry type support for ClickHouse 26.3
ClickHouse 26.3 added a Geometry data type to system.data_type_families. Also removes temporary CI debug output. https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc
1 parent a65f45c commit 6baea3b

2 files changed

Lines changed: 2 additions & 18 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -104,24 +104,7 @@ jobs:
104104
dependency-versions: "${{ matrix.dependency-versions }}"
105105

106106
- name: "Run PHPUnit"
107-
run: |
108-
vendor/bin/phpunit --testdox 2>&1 | tee /tmp/phpunit-output.txt
109-
exit ${PIPESTATUS[0]}
110-
111-
- name: "Post PHPUnit output on failure"
112-
if: failure()
113-
uses: actions/github-script@v7
114-
with:
115-
script: |
116-
const fs = require('fs');
117-
const output = fs.readFileSync('/tmp/phpunit-output.txt', 'utf8');
118-
const body = `## PHPUnit failure: PHP ${{ matrix.php-version }}, ClickHouse ${{ matrix.clickhouse-version }}\n\`\`\`\n${output.slice(0, 10000)}\n\`\`\``;
119-
await github.rest.issues.createComment({
120-
owner: context.repo.owner,
121-
repo: context.repo.repo,
122-
issue_number: context.issue.number,
123-
body: body
124-
});
107+
run: "vendor/bin/phpunit"
125108

126109
upload_coverage:
127110
name: "Upload coverage to Codecov"

src/Param/ParamValueConverterRegistry.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ public function __construct(array $registry = [])
202202
array_map($formatPolygonOrMultiLineString, $vv),
203203
));
204204
})($v),
205+
'Geometry' => $noopStringConverter,
205206

206207
'Array' => fn (array|string $v, Type $type) => is_string($v)
207208
? $v

0 commit comments

Comments
 (0)