[DeadCode] Handle with middle default not null on RemoveNullArgOnNullDefaultParamRector (rectorphp#7565)

* [DeadCode] Handle with middle default not null on RemoveNullArgOnNullDefaultParamRector

* [DeadCode] Handle with middle default not null on RemoveNullArgOnNullDefaultParamRector

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules-tests/DeadCode/Rector/MethodCall/RemoveNullArgOnNullDefaultParamRector/Fixture/handle_middle_default_not_null.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector\Source\SomeExternalClass;
+
+class HandleMiddleDefaultNotNull
+{
+    public function get(SomeExternalClass $someExternalClass)
+    {
+        $someExternalClass->withMiddleNotNullDefault(null, 1, null, null);
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector\Source\SomeExternalClass;
+
+class HandleMiddleDefaultNotNull
+{
+    public function get(SomeExternalClass $someExternalClass)
+    {
+        $someExternalClass->withMiddleNotNullDefault(null, 1);
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/MethodCall/RemoveNullArgOnNullDefaultParamRector/Source/SomeExternalClass.php

@@ -15,4 +15,8 @@ public function callWithDefaultNull(?string $name = null)
     public static function staticCallWithDefaultNull(?int $id = null)
     {
     }
+
+    public static function withMiddleNotNullDefault(?int $id = null, int $data = 1, ?string $name = null, ?string $item = null)
+    {
+    }
 }

rules/DeadCode/Rector/MethodCall/RemoveNullArgOnNullDefaultParamRector.php

@@ -88,27 +88,33 @@ public function refactor(Node $node): StaticCall|MethodCall|New_|null
 
         $hasChanged = false;
 
-        foreach ($node->getArgs() as $position => $arg) {
-            if ($arg->unpack) {
+        $args = $node->getArgs();
+        $lastArgPosition = count($args) - 1;
+        for ($position = $lastArgPosition; $position >=0; --$position) {
+            if (! isset($args[$position])) {
                 continue;
             }
 
+            $arg = $args[$position];
+            if ($arg->unpack) {
+                break;
+            }
+
             // skip named args
             if ($arg->name instanceof Node) {
-                continue;
+                break;
             }
 
             if (! $this->valueResolver->isNull($arg->value)) {
-                continue;
+                break;
             }
 
             $nullPositions = $this->callLikeParamDefaultResolver->resolveNullPositions($node);
             if (! in_array($position, $nullPositions)) {
-                continue;
+                break;
             }
 
             unset($node->args[$position]);
-
             $hasChanged = true;
         }