Bump PHPStan 2.1.26 and fixes phpstan notice (rectorphp#7296)

* Bump PHPStan 2.1.26 and fixes phpstan notice

* Fix on PropertyFetchTypeResolver: on PropertyFetch, use hasInstanceProperty() and hasInstanceProperty()

* Fix to use hasStaticProperty() on ConvertStaticToSelfRector

* Fix to use hasInstanceProperty() on MissingPropertiesResolver as locate property fetch name

* Fix

Author: samsonasik

build/target-repository/composer.json

@@ -9,7 +9,7 @@
     ],
     "require": {
         "php": "^7.4|^8.0",
-        "phpstan/phpstan": "^2.1.18"
+        "phpstan/phpstan": "^2.1.26"
     },
     "autoload": {
         "files": [

composer.json

@@ -24,7 +24,7 @@
         "ocramius/package-versions": "^2.10",
         "ondram/ci-detector": "^4.2",
         "phpstan/phpdoc-parser": "^2.2",
-        "phpstan/phpstan": "^2.1.18",
+        "phpstan/phpstan": "^2.1.26",
         "react/event-loop": "^1.5",
         "react/promise": "^3.2",
         "react/socket": "^1.16",

rules/CodeQuality/NodeAnalyzer/MissingPropertiesResolver.php

@@ -34,7 +34,7 @@ public function resolve(Class_ $class, ClassReflection $classReflection, array $
             }
 
             // 2. is part of class docblock or another magic, skip it
-            if ($classReflection->hasProperty($definedPropertyWithType->getName())) {
+            if ($classReflection->hasInstanceProperty($definedPropertyWithType->getName())) {
                 continue;
             }
 

rules/CodeQuality/Rector/Class_/ConvertStaticToSelfRector.php

@@ -143,7 +143,7 @@ private function shouldSkip(
         // native members.
         $hasMember = match (true) {
             $node instanceof StaticPropertyFetch => $isFinal
-                ? $classReflection->hasProperty($name)
+                ? $classReflection->hasStaticProperty($name)
                 : $classReflection->hasNativeProperty($name),
             $node instanceof StaticCall => $isFinal
                 ? $classReflection->hasMethod($name)
@@ -157,7 +157,7 @@ private function shouldSkip(
 
         $reflection = match (true) {
             $node instanceof StaticPropertyFetch => $isFinal
-                ? $classReflection->getProperty($name, $scope)
+                ? $classReflection->getStaticProperty($name)
                 : $classReflection->getNativeProperty($name),
             $node instanceof StaticCall => $isFinal
                 ? $classReflection->getMethod($name, $scope)

rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php

@@ -131,7 +131,7 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-            if (! $classReflection->hasProperty($propertyFetchName) || $classReflection->isBuiltin()) {
+            if (! $classReflection->hasInstanceProperty($propertyFetchName) || $classReflection->isBuiltin()) {
                 $newNodes[] = $this->replaceToPropertyExistsWithNullCheck(
                     $issetExpr->var,
                     $propertyFetchName,

rules/Privatization/Guard/ParentPropertyLookupGuard.php

@@ -128,7 +128,7 @@ private function isFoundInMethodStmts(array $stmts, string $propertyName, string
     private function isGuardedByParents(array $parentClassReflections, string $propertyName, string $className): bool
     {
         foreach ($parentClassReflections as $parentClassReflection) {
-            if ($parentClassReflection->hasProperty($propertyName)) {
+            if ($parentClassReflection->hasInstanceProperty($propertyName) || $parentClassReflection->hasStaticProperty($propertyName)) {
                 return false;
             }
 

src/NodeManipulator/PropertyManipulator.php

@@ -155,7 +155,7 @@ public function isUsedByTrait(ClassReflection $classReflection, string $property
     public function hasTraitWithSamePropertyOrWritten(ClassReflection $classReflection, string $propertyName): bool
     {
         foreach ($classReflection->getTraits() as $traitUse) {
-            if ($traitUse->hasProperty($propertyName)) {
+            if ($traitUse->hasInstanceProperty($propertyName) || $traitUse->hasStaticProperty($propertyName)) {
                 return true;
             }
 

src/NodeTypeResolver/NodeTypeResolver/PropertyFetchTypeResolver.php

@@ -82,7 +82,7 @@ private function getVendorPropertyFetchType(PropertyFetch $propertyFetch): Type
         }
 
         $classReflection = $this->reflectionProvider->getClass($varType->getClassName());
-        if (! $classReflection->hasProperty($propertyName)) {
+        if (! $classReflection->hasInstanceProperty($propertyName)) {
             return new MixedType();
         }
 
@@ -91,7 +91,7 @@ private function getVendorPropertyFetchType(PropertyFetch $propertyFetch): Type
             return new MixedType();
         }
 
-        $extendedPropertyReflection = $classReflection->getProperty($propertyName, $propertyFetchScope);
+        $extendedPropertyReflection = $classReflection->getInstanceProperty($propertyName, $propertyFetchScope);
 
         return $extendedPropertyReflection->getReadableType();
     }