Skip to content

Commit 6fa6e9f

Browse files
committed
Fix a re-order issue, and some ownership things on images
1 parent f0e02a6 commit 6fa6e9f

6 files changed

Lines changed: 41 additions & 15 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1458759122
1+
1460677669

.sandstorm/sandstorm-pkgdef.capnp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ const pkgdef :Spk.PackageDefinition = (
1919

2020
appTitle = (defaultText = "Annotate"),
2121

22-
appVersion = 5, # Increment this for every release.
22+
appVersion = 6, # Increment this for every release.
2323

24-
appMarketingVersion = (defaultText = "1.2.1"),
24+
appMarketingVersion = (defaultText = "1.3.0"),
2525
# Human-readable representation of appVersion. Should match the way you
2626
# identify versions of your app in documentation and marketing.
2727

client/directives/anDropbox.directive.js

Lines changed: 25 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,41 @@ angular.module('annotate').directive('anDropbox',
2121
{'sort': {'uploadedAt': -1}}
2222
).fetch()
2323

24+
// Let's also check what the most recent
25+
// highest ordering is, and add it to the end.
26+
27+
var highestOrder = Images.find(
28+
{},
29+
{'sort': {'metadata.order': -1}}
30+
).fetch()[0].metadata.order
31+
2432
Images.insert(file, function(err, newFile) {
2533
if (err) console.log('error insterting image', err);
2634

35+
let updateSetForNewFile = {
36+
'metadata.owner': Meteor.user(),
37+
'metadata.order': highestOrder + 1
38+
}
39+
2740
if (existingImages.length > 0) {
2841
existingImages.forEach(function(img) {
29-
Images.update({_id: img._id},
30-
{$set: {'metadata.newest': newFile._id}})
42+
Images.update({_id: img._id},
43+
{$set: {'metadata.newest': newFile._id}})
3144
})
45+
3246
Images.update({_id: existingImages[0]._id},
3347
{$set: {'metadata.next': newFile._id}})
34-
Images.update({_id: newFile._id},
35-
{$set: {
36-
'metadata.previous': existingImages[0]._id,
37-
'metadata.description': existingImages[0].metadata.description,
38-
'metadata.order': existingImages[0].metadata.order
39-
}})
48+
49+
updateSetForNewFile['metadata.previous'] = existingImages[0]._id
50+
if (existingImages[0].metadata) {
51+
updateSetForNewFile['metadata.description'] = existingImages[0].metadata.description
52+
updateSetForNewFile['metadata.order'] = existingImages[0].metadata.order
53+
}
4054
}
4155

56+
Images.update({_id: newFile._id},
57+
{$set: updateSetForNewFile})
58+
4259
$scope.$apply(function() {
4360
$timeout(function() {
4461
$scope.onImageAdded();

client/index.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@
7070

7171
<header>
7272
<div class="image-meta">
73-
{{ image.metadata.order + 1 }}.
73+
<span class="order" ng-if="image.metadata.order !== undefined">
74+
{{ image.metadata.order + 1 }}.
75+
</span>
7476
<span href="#"
7577
editable-text="image.metadata.description"
7678
e-form="descriptionEditForm"
@@ -95,7 +97,8 @@
9597
></div>
9698
<footer>
9799
<span class="has-older" ng-show="image.metadata.previous">Has an older version.</span>
98-
<span class="uploaded-by">Uploaded by <span ng-bind="user.services.sandstorm.preferredHandle">.</span>
100+
<span class="uploaded-by" ng-if="image.metadata.owner !== undefined">Uploaded by <span ng-bind="image.metadata.owner.services.sandstorm.preferredHandle">.</span></span>
101+
<div style="clear:both;"></div>
99102
</footer>
100103
</div>
101104
</div>

client/styles/components/image-container.import.less

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.images-container-title.double .image-container {
2-
width: 40%;
2+
width: 44%;
33
display: inline-block;
4-
margin: 1rem 5%;
4+
margin: 1rem 3%;
55
}
66

77
.image-container {

meta/changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# 1.3.0
2+
3+
* Adding a file that already exists will replace the existing file, and references to the previous file will be stored. (Files are not deleted).
4+
* We now ask for confirmation before adding an annotation.
5+
* You can now view images in one or two columns.
6+
17
# 1.2.0
28

39
* Annotations now maintain an order and don't change order. They're unique in the entire grain too.

0 commit comments

Comments
 (0)