Skip to content

Add elements starting with http(s) as clickable links in the map bubbles #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redmanmale wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add elements starting with http(s) as clickable links in the map bubbles #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af1b206
Add elements starting with http(s) as clickable links in the map bubbles
redmanmale Oct 1, 2022
588506f
fix link view
redmanmale Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions datasette_cluster_map/static/datasette-cluster-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,19 @@ const clusterMapMarkerContent = (row) => {
return html.join("");
}
}

function addAsLink(element, parent) {
if (element.startsWith('http://') || element.startsWith('https://')) {
const text = document.createTextNode('link\n');
var link = document.createElement('a');
link.setAttribute('href', element);
link.appendChild(text);
parent.appendChild(link);
} else {
parent.appendChild(document.createTextNode(element));
}
};

// Otherwise, use a <dl>
const dl = document.createElement("dl");
Object.keys(row).forEach((key) => {
Expand All @@ -164,15 +177,20 @@ const clusterMapMarkerContent = (row) => {
label = JSON.stringify(value);
}
}
dd.appendChild(document.createTextNode(label));
const parts = label.toString().split('\n');
if (parts.length > 1) {
parts.forEach((part) => addAsLink(part, dd));
} else {
addAsLink(label.toString(), dd);
}
if (extra) {
dd.appendChild(extra);
}
dl.appendChild(dt);
dl.appendChild(dd);
});
return (
'<dl class="cluster-map-dl" style="height: 200px; overflow: auto">' +
'<dl class="cluster-map-dl" style="height: 100%; overflow: auto">' +
dl.innerHTML +
"</dl>"
);
Expand Down