Store a leaflet map instance on a DOM element so other plugins can write on the same map#53
Open
etjones wants to merge 1 commit into
Open
Store a leaflet map instance on a DOM element so other plugins can write on the same map#53etjones wants to merge 1 commit into
etjones wants to merge 1 commit into
Conversation
…'.leaflet-container' DOM element. Other plugins can then access this handle and add to the map as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On map creation, store the leaflet map instance on the DOM element
.leaflet-containerasdatasetteClusterMap. Another plugin can then use that instance to write to the same map, getting the benefits ofdatasette-cluster-map's logic without.Another plugin can then do
I guess that this allows plugins to the
datasette-cluster-mapplugin. Yo dawg...Includes a sanity-check test to verify that the handle is available