Show facet option for the first column on view pages#2810
Open
cycsmail wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2045
The cog menu was hiding "Facet by this" on the first column of a view. The check used a positional
th:first-of-typeheuristic to skip the special row-link column, but on a view the first column is a real data column so it got skipped too.Switched it to key off the
data-is-link-columnattribute the template already sets for the special link column (the same thinghasMultipleVisibleColumnsand the mobile column menu already use), so the link column is still skipped but a view's first column now gets the facet option.Added a test that drives
buildColumnActionItemsvia node against a minimal fake DOM: the first column of a view now offers faceting, while the link column and a single pk still don't.