Return 400, not 500, for malformed _search_ and _through params#2851
Open
santhreal wants to merge 1 commit into
Open
Return 400, not 500, for malformed _search_ and _through params#2851santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
Two filter hooks crashed with an unhandled 500 on malformed query strings:
- search_filters: a key that starts with _search but is not the
_search_column= form (e.g. ?_searchcol=x) reached
key.split("_search_", 1)[1] and raised IndexError. Such a key names
no column, so skip it.
- through_filters: ?_through= was passed straight to json.loads() and
indexed for table/column/value, so invalid JSON, a missing key, or a
non-object value raised JSONDecodeError/KeyError/TypeError. Raise
BadRequest instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two malformed query-string parameters returned 500 instead of 400.
?_searchcol=xstarts with_searchbut is not the?_search_col=form, sokey.split("_search_", 1)[1]raisedIndexError; such keys are now ignored since they name no column. A malformed?_through=value was passed straight tojson.loadsand then indexed, raisingJSONDecodeError/KeyError/TypeError; it now raisesBadRequest.Adds tests for the malformed cases and confirms a valid column search still works.