Fix get_all_foreign_keys crash sorting implicit foreign key targets#2852
Open
santhreal wants to merge 1 commit into
Open
Fix get_all_foreign_keys crash sorting implicit foreign key targets#2852santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
A foreign key that targets a table's implicit primary key has other_column == None. When two keys to the same table were sorted, the (other_table, column, other_column) sort key compared None to a string and raised TypeError. Coerce the string parts to "" so the sort key is totally ordered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sort key
(other_table, column, other_column)comparedNoneagainst astrand raisedTypeError. A foreign key targeting a table's implicit primary key hasother_column = None, so any schema mixing implicit and explicit foreign keys to the same table crashedget_all_foreign_keys.Coerce the sort-key parts to
"". Adds a test with both foreign-key shapes asserting the sorted result.